Bluetooth: hci_sync: Fix smatch warning

Commit Message

Luiz Augusto von Dentz Feb. 27, 2023, 11:52 p.m. UTC

From: Luiz Augusto von Dentz <[e-mail]>

This fixes the following new warning:

net/bluetooth/hci_sync.c:2403 hci_pause_addr_resolution() warn: missing
error code? 'err'

Reported-by: kernel test robot <[e-mail]>
Reported-by: Dan Carpenter <[e-mail]>
Link: https://lore.kernel.org/r/[e-mail]/
Signed-off-by: Luiz Augusto von Dentz <[e-mail]>
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

[e-mail] Feb. 28, 2023, 1:17 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=725355

---Test result---

Test Summary:
CheckPatch                    FAIL      0.82 seconds
GitLint                       PASS      0.24 seconds
SubjectPrefix                 PASS      0.08 seconds
BuildKernel                   PASS      32.28 seconds
CheckAllWarning               PASS      34.37 seconds
CheckSparse                   PASS      38.71 seconds
CheckSmatch                   PASS      108.28 seconds
BuildKernel32                 PASS      30.33 seconds
TestRunnerSetup               PASS      438.50 seconds
TestRunner_l2cap-tester       PASS      15.83 seconds
TestRunner_iso-tester         PASS      16.59 seconds
TestRunner_bnep-tester        PASS      5.31 seconds
TestRunner_mgmt-tester        PASS      107.67 seconds
TestRunner_rfcomm-tester      PASS      8.70 seconds
TestRunner_sco-tester         PASS      7.87 seconds
TestRunner_ioctl-tester       PASS      9.24 seconds
TestRunner_mesh-tester        PASS      6.70 seconds
TestRunner_smp-tester         PASS      7.82 seconds
TestRunner_userchan-tester    PASS      5.65 seconds
IncrementalBuild              PASS      28.83 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: hci_sync: Fix smatch warning
WARNING: A patch subject line should describe the change not the tool that found it
#69: 
Subject: [PATCH] Bluetooth: hci_sync: Fix smatch warning

total: 0 errors, 1 warnings, 0 checks, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13154313.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth

[e-mail] March 2, 2023, 8:10 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Mon, 27 Feb 2023 15:52:55 -0800 you wrote:
> From: Luiz Augusto von Dentz <[e-mail]>
> 
> This fixes the following new warning:
> 
> net/bluetooth/hci_sync.c:2403 hci_pause_addr_resolution() warn: missing
> error code? 'err'
> 
> [...]

Here is the summary with links:
  - Bluetooth: hci_sync: Fix smatch warning
    https://git.kernel.org/bluetooth/bluetooth-next/c/80fb206d2840

You are awesome, thank you!

Patch

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 7e152e912e8c..561a519a11bd 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -2400,7 +2400,7 @@  static int hci_pause_addr_resolution(struct hci_dev *hdev)
 
 	/* Return if address resolution is disabled and RPA is not used. */
 	if (!err && scan_use_rpa(hdev))
-		return err;
+		return 0;
 
 	hci_resume_advertising_sync(hdev);
 	return err;