obexd: launch obexd directly from dbus service

Commit Message

Erfaun Atabakhsh March 1, 2023, 5:02 a.m. UTC

Whenver obexd is summoned via dbus with the systemdservice file, the
daemon exits with the following error: Failed to start org.bluez.obex service: Process org.bluez.obex exite.
Irregardless of obex.service is enabled and running in the background,
whenver an app calls for obexd via dbus, it seems like it forces to use
the systemdservice, and that for whatever reason doesn't work.

Therefore, I propose instead of having systemd launch obexd, obexd
should be launched directly from the dbus service. Using this patch has
fixed all of my woes described in https://bugs.kde.org/show_bug.cgi?id=464929#c3
, and has worked both on KDE and GNOME. This is my first email patch, so
I look forward to you all's feedback and critical response!
---
 obexd/src/org.bluez.obex.service | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

[e-mail] March 1, 2023, 6:13 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=725708

---Test result---

Test Summary:
CheckPatch                    FAIL      0.72 seconds
GitLint                       FAIL      0.52 seconds
BuildEll                      PASS      27.14 seconds
BluezMake                     PASS      859.79 seconds
MakeCheck                     PASS      11.92 seconds
MakeDistcheck                 PASS      150.99 seconds
CheckValgrind                 PASS      244.70 seconds
CheckSmatch                   PASS      331.61 seconds
bluezmakeextell               PASS      98.85 seconds
IncrementalBuild              PASS      715.91 seconds
ScanBuild                     PASS      1021.10 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
obexd: launch obexd directly from dbus service
WARNING:TYPO_SPELLING: 'Whenver' may be misspelled - perhaps 'Whenever'?
#80: 
Whenver obexd is summoned via dbus with the systemdservice file, the
^^^^^^^

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#81: 
daemon exits with the following error: Failed to start org.bluez.obex service: Process org.bluez.obex exite.

WARNING:TYPO_SPELLING: 'whenver' may be misspelled - perhaps 'whenever'?
#83: 
whenver an app calls for obexd via dbus, it seems like it forces to use
^^^^^^^

/github/workspace/src/src/13155603.patch total: 0 errors, 3 warnings, 5 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13155603.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
obexd: launch obexd directly from dbus service

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
4: B1 Line exceeds max length (108>80): "daemon exits with the following error: Failed to start org.bluez.obex service: Process org.bluez.obex exite."


---
Regards,
Linux Bluetooth

Patch

diff --git a/obexd/src/org.bluez.obex.service b/obexd/src/org.bluez.obex.service
index a53808884..efbd8f1d9 100644
--- a/obexd/src/org.bluez.obex.service
+++ b/obexd/src/org.bluez.obex.service
@@ -1,4 +1,3 @@ 
 [D-BUS Service]
 Name=org.bluez.obex
-Exec=/bin/false
-SystemdService=dbus-org.bluez.obex.service
+Exec=/usr/lib/bluetooth/obexd