| Message ID | 20230306223221.536377-1-brian.gix@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | eaa2b72585a3b796be1a369384c7ba42feb33ebd |
| Headers | show |
| Series | Bluetooth: Remove "Power-on" check from Mesh feature | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | warning | WARNING: 'dependancy' may be misspelled - perhaps 'dependency'? #85: Fixes: Unintended Bluetooth startup order dependancy ^^^^^^^^^^ total: 0 errors, 1 warnings, 0 checks, 12 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13162455.patch has style problems, please review. NOTE: Ignored message types: UNKNOWN_COMMIT_ID NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=727113
---Test result---
Test Summary:
CheckPatch FAIL 1.05 seconds
GitLint PASS 0.26 seconds
SubjectPrefix PASS 0.07 seconds
BuildKernel PASS 43.10 seconds
CheckAllWarning PASS 47.38 seconds
CheckSparse PASS 52.48 seconds
CheckSmatch PASS 142.54 seconds
BuildKernel32 PASS 41.20 seconds
TestRunnerSetup PASS 590.44 seconds
TestRunner_l2cap-tester PASS 19.97 seconds
TestRunner_iso-tester PASS 23.30 seconds
TestRunner_bnep-tester PASS 7.69 seconds
TestRunner_mgmt-tester PASS 142.76 seconds
TestRunner_rfcomm-tester PASS 12.07 seconds
TestRunner_sco-tester PASS 10.67 seconds
TestRunner_ioctl-tester PASS 12.58 seconds
TestRunner_mesh-tester PASS 9.36 seconds
TestRunner_smp-tester PASS 10.42 seconds
TestRunner_userchan-tester PASS 7.90 seconds
IncrementalBuild PASS 39.43 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: Remove "Power-on" check from Mesh feature
WARNING: 'dependancy' may be misspelled - perhaps 'dependency'?
#85:
Fixes: Unintended Bluetooth startup order dependancy
^^^^^^^^^^
total: 0 errors, 1 warnings, 0 checks, 12 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13162455.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 6 Mar 2023 14:32:21 -0800 you wrote: > The Bluetooth mesh experimental feature enable was requiring the > controller to be powered off in order for the Enable to work. Mesh is > supposed to be enablable regardless of the controller state, and created > an unintended requirement that the mesh daemon be started before the > classic bluetoothd daemon. > > Fixes: Unintended Bluetooth startup order dependancy > Signed-off-by: Brian Gix <brian.gix@gmail.com> > > [...] Here is the summary with links: - Bluetooth: Remove "Power-on" check from Mesh feature https://git.kernel.org/bluetooth/bluetooth-next/c/eaa2b72585a3 You are awesome, thank you!
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 0dd30a3beb77..7576db8eb83e 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -4627,12 +4627,6 @@ static int set_mgmt_mesh_func(struct sock *sk, struct hci_dev *hdev, MGMT_OP_SET_EXP_FEATURE, MGMT_STATUS_INVALID_INDEX); - /* Changes can only be made when controller is powered down */ - if (hdev_is_powered(hdev)) - return mgmt_cmd_status(sk, hdev->id, - MGMT_OP_SET_EXP_FEATURE, - MGMT_STATUS_REJECTED); - /* Parameters are limited to a single octet */ if (data_len != MGMT_SET_EXP_FEATURE_SIZE + 1) return mgmt_cmd_status(sk, hdev->id,
The Bluetooth mesh experimental feature enable was requiring the controller to be powered off in order for the Enable to work. Mesh is supposed to be enablable regardless of the controller state, and created an unintended requirement that the mesh daemon be started before the classic bluetoothd daemon. Fixes: Unintended Bluetooth startup order dependancy Signed-off-by: Brian Gix <brian.gix@gmail.com> --- net/bluetooth/mgmt.c | 6 ------ 1 file changed, 6 deletions(-)