| Message ID | 20230308005158.2661414-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 581aae6a2722e69479f4846e7b00c43fdf112b4c |
| Headers | show |
| Series | [BlueZ,1/2] device: Fix not always storing device info | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | warning | ScanBuild: src/gatt-database.c:1152:10: warning: Value stored to 'bits' during its initialization is never read uint8_t bits[] = { BT_GATT_CHRC_CLI_FEAT_ROBUST_CACHING, ^~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=727684
---Test result---
Test Summary:
CheckPatch PASS 0.71 seconds
GitLint PASS 0.49 seconds
BuildEll PASS 26.25 seconds
BluezMake PASS 763.65 seconds
MakeCheck PASS 11.06 seconds
MakeDistcheck PASS 154.66 seconds
CheckValgrind PASS 241.74 seconds
CheckSmatch PASS 323.62 seconds
bluezmakeextell PASS 97.21 seconds
IncrementalBuild PASS 1235.69 seconds
ScanBuild WARNING 983.36 seconds
Details
##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
src/gatt-database.c:1152:10: warning: Value stored to 'bits' during its initialization is never read
uint8_t bits[] = { BT_GATT_CHRC_CLI_FEAT_ROBUST_CACHING,
^~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
---
Regards,
Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 7 Mar 2023 16:51:57 -0800 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > When updating the device address check if the device is marked as > temporary before attempting to call store_device_info otherwise it will > have no effect and instead btd_device_set_temporary must be called. > --- > src/device.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Here is the summary with links: - [BlueZ,1/2] device: Fix not always storing device info https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=581aae6a2722 - [BlueZ,2/2] gatt: Fix creating duplicated objects https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3842320f450e You are awesome, thank you!
diff --git a/src/device.c b/src/device.c index df50ce7b4f6c..652c03606b9e 100644 --- a/src/device.c +++ b/src/device.c @@ -4412,7 +4412,10 @@ void device_update_addr(struct btd_device *device, const bdaddr_t *bdaddr, bacpy(&device->bdaddr, bdaddr); device->bdaddr_type = bdaddr_type; - store_device_info(device); + if (device->temporary) + btd_device_set_temporary(device, false); + else + store_device_info(device); g_dbus_emit_property_changed(dbus_conn, device->path, DEVICE_INTERFACE, "Address");
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> When updating the device address check if the device is marked as temporary before attempting to call store_device_info otherwise it will have no effect and instead btd_device_set_temporary must be called. --- src/device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)