diff mbox series

[BlueZ,v3,1/2] mesh: Fix uninitialized memory usage

Message ID 20230313231152.59147-1-brian.gix@gmail.com (mailing list archive)
State Accepted
Commit 5934f133d44aeda4e682bd15daf2dc93bb7d355f
Headers show
Series [BlueZ,v3,1/2] mesh: Fix uninitialized memory usage | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Brian Gix March 13, 2023, 11:11 p.m. UTC
When attempting to cancel an unknown Scan request structure must be
NULL initialized.
---
 mesh/manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com March 14, 2023, 12:19 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=729657

---Test result---

Test Summary:
CheckPatch                    PASS      1.05 seconds
GitLint                       PASS      0.69 seconds
BuildEll                      PASS      26.54 seconds
BluezMake                     PASS      759.22 seconds
MakeCheck                     PASS      11.27 seconds
MakeDistcheck                 PASS      150.04 seconds
CheckValgrind                 PASS      240.84 seconds
CheckSmatch                   PASS      321.44 seconds
bluezmakeextell               PASS      97.21 seconds
IncrementalBuild              PASS      1224.68 seconds
ScanBuild                     PASS      977.66 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org March 14, 2023, 9:40 p.m. UTC | #2
Hello:

This series was applied to bluetooth/bluez.git (master)
by Brian Gix <brian.gix@gmail.com>:

On Mon, 13 Mar 2023 16:11:51 -0700 you wrote:
> When attempting to cancel an unknown Scan request structure must be
> NULL initialized.
> ---
>  mesh/manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ,v3,1/2] mesh: Fix uninitialized memory usage
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5934f133d44a
  - [BlueZ,v3,2/2] mesh: Loopback unprovisioned beacons
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7c0fb2fefb6a

You are awesome, thank you!
diff mbox series

Patch

diff --git a/mesh/manager.c b/mesh/manager.c
index e16dbc513..0c98721bf 100644
--- a/mesh/manager.c
+++ b/mesh/manager.c
@@ -709,7 +709,7 @@  static struct l_dbus_message *start_scan_call(struct l_dbus *dbus,
 	req = l_queue_remove_if(scans, by_node_svr, &new_req);
 
 	if (!req)
-		req = l_malloc(sizeof(new_req));
+		req = l_new(struct scan_req, 1);
 
 	if (req->timeout) {
 		l_timeout_remove(req->timeout);