[v1] Bluetooth: btnxpuart: Deasset UART break before closing serdev device

Commit Message

Neeraj Sanjay Kale April 3, 2023, 12:24 p.m. UTC

This adds a call to ps_wakeup() before closing the serdev device, to
de-assert UART break.

Signed-off-by: Neeraj Sanjay Kale <[e-mail]>
---
 drivers/bluetooth/btnxpuart.c | 1 +
 1 file changed, 1 insertion(+)

Comments

[e-mail] April 3, 2023, 1:13 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=736375

---Test result---

Test Summary:
CheckPatch                    PASS      0.53 seconds
GitLint                       PASS      0.25 seconds
SubjectPrefix                 PASS      0.08 seconds
BuildKernel                   PASS      31.38 seconds
CheckAllWarning               PASS      35.00 seconds
CheckSparse                   PASS      38.82 seconds
CheckSmatch                   PASS      108.88 seconds
BuildKernel32                 PASS      30.51 seconds
TestRunnerSetup               PASS      435.38 seconds
TestRunner_l2cap-tester       PASS      15.79 seconds
TestRunner_iso-tester         PASS      15.60 seconds
TestRunner_bnep-tester        PASS      5.01 seconds
TestRunner_mgmt-tester        PASS      107.86 seconds
TestRunner_rfcomm-tester      PASS      8.05 seconds
TestRunner_sco-tester         PASS      7.46 seconds
TestRunner_ioctl-tester       PASS      8.74 seconds
TestRunner_mesh-tester        PASS      6.42 seconds
TestRunner_smp-tester         PASS      7.32 seconds
TestRunner_userchan-tester    PASS      5.23 seconds
IncrementalBuild              PASS      28.77 seconds



---
Regards,
Linux Bluetooth

[e-mail] April 6, 2023, 9 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Mon,  3 Apr 2023 17:54:28 +0530 you wrote:
> This adds a call to ps_wakeup() before closing the serdev device, to
> de-assert UART break.
> 
> Signed-off-by: Neeraj Sanjay Kale <[e-mail]>
> ---
>  drivers/bluetooth/btnxpuart.c | 1 +
>  1 file changed, 1 insertion(+)

Here is the summary with links:
  - [v1] Bluetooth: btnxpuart: Deasset UART break before closing serdev device
    https://git.kernel.org/bluetooth/bluetooth-next/c/051711980f5a

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 34f44da9ef4d..ad9e25e0c350 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -1167,6 +1167,7 @@  static int btnxpuart_close(struct hci_dev *hdev)
 {
 	struct btnxpuart_dev *nxpdev = hci_get_drvdata(hdev);
 
+	ps_wakeup(nxpdev);
 	serdev_device_close(nxpdev->serdev);
 	clear_bit(BTNXPUART_SERDEV_OPEN, &nxpdev->tx_state);
 	return 0;