Bluetooth: hci_qca: mark OF related data as maybe unused

Commit Message

Steev Klimaszewski April 12, 2023, 11:58 p.m. UTC

The driver can be compile tested with !CONFIG_OF making certain data
unused.

Signed-off-by: Steev Klimaszewski <[e-mail]>
---
There was a patch to mark OF related data as maybe unused in flight when
I was doing my bluetooth driver work and I didn't notice it.  Since I
don't build on !CONFIG_OF systems, I hadn't seen the warning.  This
patch simply marks our data as maybe unused as well.
---
 drivers/bluetooth/hci_qca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 7d8214bba44c1aa6a75921a09a691945d26a8d43
change-id: 20230412-bluetooth-c7590ef622d3

Best regards,

Comments

[e-mail] April 13, 2023, 1:09 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=739309

---Test result---

Test Summary:
CheckPatch                    PASS      0.67 seconds
GitLint                       PASS      0.33 seconds
SubjectPrefix                 PASS      0.12 seconds
BuildKernel                   PASS      33.84 seconds
CheckAllWarning               PASS      36.96 seconds
CheckSparse                   PASS      41.79 seconds
CheckSmatch                   PASS      115.54 seconds
BuildKernel32                 PASS      32.78 seconds
TestRunnerSetup               PASS      465.37 seconds
TestRunner_l2cap-tester       PASS      16.85 seconds
TestRunner_iso-tester         PASS      16.59 seconds
TestRunner_bnep-tester        PASS      5.41 seconds
TestRunner_mgmt-tester        PASS      112.48 seconds
TestRunner_rfcomm-tester      PASS      8.69 seconds
TestRunner_sco-tester         PASS      8.32 seconds
TestRunner_ioctl-tester       PASS      9.27 seconds
TestRunner_mesh-tester        PASS      6.83 seconds
TestRunner_smp-tester         PASS      7.94 seconds
TestRunner_userchan-tester    PASS      5.69 seconds
IncrementalBuild              PASS      31.06 seconds



---
Regards,
Linux Bluetooth

[e-mail] April 14, 2023, 8:10 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Wed, 12 Apr 2023 18:58:17 -0500 you wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused.
> 
> Signed-off-by: Steev Klimaszewski <[e-mail]>
> ---
> There was a patch to mark OF related data as maybe unused in flight when
> I was doing my bluetooth driver work and I didn't notice it.  Since I
> don't build on !CONFIG_OF systems, I hadn't seen the warning.  This
> patch simply marks our data as maybe unused as well.
> 
> [...]

Here is the summary with links:
  - Bluetooth: hci_qca: mark OF related data as maybe unused
    https://git.kernel.org/bluetooth/bluetooth-next/c/875d76c2f7c1

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 1597797ff169..1b064504b388 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1891,7 +1891,7 @@  static const struct qca_device_data qca_soc_data_wcn6750 __maybe_unused = {
 	.capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES,
 };
 
-static const struct qca_device_data qca_soc_data_wcn6855 = {
+static const struct qca_device_data qca_soc_data_wcn6855 __maybe_unused = {
 	.soc_type = QCA_WCN6855,
 	.vregs = (struct qca_vreg []) {
 		{ "vddio", 5000 },