diff mbox series

[2/2] Bluetooth: hci_qca: fix debugfs registration

Message ID 20230424124852.12625-3-johan+linaro@kernel.org (mailing list archive)
State New, archived
Headers show
Series Bluetooth: fix debugfs registration | expand


Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint fail WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 10: B3 Line contains hard tab characters (\t): " debugfs: Directory 'ibs' with parent 'hci0' already present!" 15: B3 Line contains hard tab characters (\t): "Cc: stable@vger.kernel.org # 4.20"
tedd_an/SubjectPrefix success Gitlint PASS
tedd_an/IncrementalBuild success Incremental Build PASS

Commit Message

Johan Hovold April 24, 2023, 12:48 p.m. UTC
Since commit 3e4be65eb82c ("Bluetooth: hci_qca: Add poweroff support
during hci down for wcn3990"), the setup callback which registers the
debugfs interface can be called multiple times.

This specifically leads to the following error when powering on the

	debugfs: Directory 'ibs' with parent 'hci0' already present!

Add a driver flag to avoid trying to register the debugfs interface more
than once.

Fixes: 3e4be65eb82c ("Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990")
Cc: stable@vger.kernel.org	# 4.20
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
 drivers/bluetooth/hci_qca.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 38ff962662ff..db020c04b3e8 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -78,7 +78,8 @@  enum qca_flags {
 enum qca_capabilities {
@@ -635,6 +636,9 @@  static void qca_debugfs_init(struct hci_dev *hdev)
 	if (!hdev->debugfs)
+	if (test_and_set_bit(QCA_DEBUGFS_CREATED, &qca->flags))
+		return;
 	ibs_dir = debugfs_create_dir("ibs", hdev->debugfs);
 	/* read only */