diff mbox series

[v2,1/2] monitor/intel: Fix not skipping unknown TLV types

Message ID 20230509235507.3424068-1-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Commit 89f8d6bae18f853ae2ab9f6de21b62469f82d84c
Headers show
Series [v2,1/2] monitor/intel: Fix not skipping unknown TLV types | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Luiz Augusto von Dentz May 9, 2023, 11:55 p.m. UTC 
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

The code was stopping at first time it detected an unknown TLV type when
it could continue:

> HCI Event: Vendor (0xff) plen 82
        Vendor Prefix (0x8780)
      Intel Extended Telemetry (0x03)
        Extended event type (0x01): Audio Link Quality Report Type (0x05)
        Unknown extended subevent 0x81
        01 01 05 81 04 88 13 00 00 82 10 6a e6 6c 00 00  ...........j.l..
        00 00 00 4b 45 53 00 00 00 00 00 83 04 00 00 00  ...KES..........
        00 84 04 01 03 07 19 85 04 3f 08 00 00 86 08 00  .........?......
        00 00 00 00 00 00 00 87 04 00 00 00 00 88 04 00  ................
        00 00 00 89 04 00 00 00 00 8a 04 b9 49 0c 00     ............I..

So this changes it to:

> HCI Event: Vendor (0xff) plen 82
        Vendor Prefix (0x8780)
      Intel Extended Telemetry (0x03)
        Extended event type (0x01): Audio Link Quality Report Type (0x05)
        Unknown extended subevent 0x81
        88 13 00 00                                      ....
        Unknown extended subevent 0x82
        04 97 6c 00 00 00 00 00 68 44 53 00 00 00 00 00  ..l.....hDS.....
        Unknown extended subevent 0x83
        00 00 00 00                                      ....
        Unknown extended subevent 0x84
        01 03 07 19                                      ....
        Unknown extended subevent 0x85
        3a 08 00 00                                      :...
        Unknown extended subevent 0x86
        00 00 00 00 00 00 00 00                          ........
        Unknown extended subevent 0x87
        00 00 00 00                                      ....
        Unknown extended subevent 0x88
        00 00 00 00                                      ....
        Unknown extended subevent 0x89
        00 00 00 00                                      ....
        Unknown extended subevent 0x8a
        9f 1a 2f 00                                      ../.
---
 monitor/intel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com May 10, 2023, 2:33 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=746268

---Test result---

Test Summary:
CheckPatch                    PASS      1.24 seconds
GitLint                       PASS      0.75 seconds
BuildEll                      PASS      33.36 seconds
BluezMake                     PASS      1118.49 seconds
MakeCheck                     PASS      13.77 seconds
MakeDistcheck                 PASS      188.73 seconds
CheckValgrind                 PASS      304.34 seconds
CheckSmatch                   PASS      415.68 seconds
bluezmakeextell               PASS      127.00 seconds
IncrementalBuild              PASS      1932.54 seconds
ScanBuild                     PASS      1303.51 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org May 10, 2023, 8 p.m. UTC | #2 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  9 May 2023 16:55:06 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> The code was stopping at first time it detected an unknown TLV type when
> it could continue:
> 
> > HCI Event: Vendor (0xff) plen 82
>         Vendor Prefix (0x8780)
>       Intel Extended Telemetry (0x03)
>         Extended event type (0x01): Audio Link Quality Report Type (0x05)
>         Unknown extended subevent 0x81
>         01 01 05 81 04 88 13 00 00 82 10 6a e6 6c 00 00  ...........j.l..
>         00 00 00 4b 45 53 00 00 00 00 00 83 04 00 00 00  ...KES..........
>         00 84 04 01 03 07 19 85 04 3f 08 00 00 86 08 00  .........?......
>         00 00 00 00 00 00 00 87 04 00 00 00 00 88 04 00  ................
>         00 00 00 89 04 00 00 00 00 8a 04 b9 49 0c 00     ............I..
> 
> [...]

Here is the summary with links:
  - [v2,1/2] monitor/intel: Fix not skipping unknown TLV types
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=89f8d6bae18f
  - [v2,2/2] monitor/intel: Skip packet/error counters if 0
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8c452c2ec173

You are awesome, thank you!
diff mbox series

Patch

diff --git a/monitor/intel.c b/monitor/intel.c
index f5e9f5932cf4..416f52503ebf 100644
--- a/monitor/intel.c
+++ b/monitor/intel.c
@@ -1606,7 +1606,8 @@  static const struct intel_tlv *process_ext_subevent(const struct intel_tlv *tlv,
 		print_text(COLOR_UNKNOWN_EXT_EVENT,
 				"Unknown extended subevent 0x%2.2x",
 				tlv->subevent_id);
-		return NULL;
+		packet_hexdump(tlv->value, tlv->length);
+		return next_tlv;
 	}
 
 	if (tlv->length != subevent->length) {