| Message ID | 20230619203032.6812-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 62032321bfe8ad13e1f17520f8935dbd1341af62 |
| Headers | show |
| Series | [BlueZ,1/5] shared/bap: Add unespecified bit in audio context to PAC records | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | warning | ScanBuild: client/player.c:3661:25: warning: Access to field 'acquiring' results in a dereference of a null pointer (loaded from variable 'ep') if (!ep && queue_find(ep->acquiring, NULL, link)) ^~~~~~~~~~~~~ 1 warning generated. |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=758478
---Test result---
Test Summary:
CheckPatch PASS 2.89 seconds
GitLint PASS 1.82 seconds
BuildEll PASS 27.80 seconds
BluezMake PASS 875.71 seconds
MakeCheck PASS 12.05 seconds
MakeDistcheck PASS 156.89 seconds
CheckValgrind PASS 259.09 seconds
CheckSmatch PASS 345.82 seconds
bluezmakeextell PASS 104.47 seconds
IncrementalBuild PASS 3647.17 seconds
ScanBuild WARNING 1066.68 seconds
Details
##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
client/player.c:3661:25: warning: Access to field 'acquiring' results in a dereference of a null pointer (loaded from variable 'ep')
if (!ep && queue_find(ep->acquiring, NULL, link))
^~~~~~~~~~~~~
1 warning generated.
---
Regards,
Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 19 Jun 2023 13:30:28 -0700 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > This makes sure unespecified bit is properly marked in both audio > contexts since that required by many platforms in order to work properly > and while doing that add proper defines to the defaults values used in > PACS. > > [...] Here is the summary with links: - [BlueZ,1/5] shared/bap: Add unespecified bit in audio context to PAC records https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=62032321bfe8 - [BlueZ,2/5] client: Print integers decimal value https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=2c9ab2d3f411 - [BlueZ,3/5] client/player: Fix auto registration of broadcast endpoint https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0053bc5472b6 - [BlueZ,4/5] client/player: Fix transport.acquire for linked transports (no matching commit) - [BlueZ,5/5] shared/bap: Pass bcode as a reference instead of value https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=95d3e66524bf You are awesome, thank you!
diff --git a/src/shared/bap.c b/src/shared/bap.c index 4b31536ee..270f0fd64 100644 --- a/src/shared/bap.c +++ b/src/shared/bap.c @@ -47,6 +47,14 @@ #define BAP_PROCESS_TIMEOUT 10 +#define PACS_SRC_LOCATION 0x00000001 +#define PACS_SNK_LOCATION 0x00000003 + +#define PACS_SRC_CTXT 0x000f +#define PACS_SUPPORTED_SRC_CTXT PACS_SRC_CTXT +#define PACS_SNK_CTXT 0x0fff +#define PACS_SUPPORTED_SNK_CTXT PACS_SNK_CTXT + struct bt_bap_pac_changed { unsigned int id; bt_bap_pac_func_t added; @@ -467,12 +475,12 @@ static struct bt_pacs *pacs_new(struct gatt_db *db) pacs = new0(struct bt_pacs, 1); /* Set default values */ - pacs->sink_loc_value = 0x00000003; - pacs->source_loc_value = 0x00000001; - pacs->sink_context_value = 0x0fff; - pacs->source_context_value = 0x000e; - pacs->supported_sink_context_value = 0x0fff; - pacs->supported_source_context_value = 0x000e; + pacs->sink_loc_value = PACS_SNK_LOCATION; + pacs->source_loc_value = PACS_SRC_LOCATION; + pacs->sink_context_value = PACS_SNK_CTXT; + pacs->source_context_value = PACS_SRC_CTXT; + pacs->supported_sink_context_value = PACS_SUPPORTED_SNK_CTXT; + pacs->supported_source_context_value = PACS_SUPPORTED_SRC_CTXT; /* Populate DB with PACS attributes */ bt_uuid16_create(&uuid, PACS_UUID);
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> This makes sure unespecified bit is properly marked in both audio contexts since that required by many platforms in order to work properly and while doing that add proper defines to the defaults values used in PACS. --- src/shared/bap.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-)