diff mbox series

[v1] Bluetooth: btintel: Add support for GalePeak

Message ID 20230628113934.824668-1-kiran.k@intel.com (mailing list archive)
State New, archived
Headers show
Series [v1] Bluetooth: btintel: Add support for GalePeak | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/SubjectPrefix success Gitlint PASS
tedd_an/BuildKernel success BuildKernel PASS
tedd_an/CheckAllWarning success CheckAllWarning PASS
tedd_an/CheckSparse success CheckSparse PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/BuildKernel32 success BuildKernel32 PASS
tedd_an/TestRunnerSetup success TestRunnerSetup PASS
tedd_an/TestRunner_l2cap-tester success TestRunner PASS
tedd_an/TestRunner_iso-tester success TestRunner PASS
tedd_an/TestRunner_bnep-tester success TestRunner PASS
tedd_an/TestRunner_mgmt-tester success TestRunner PASS
tedd_an/TestRunner_rfcomm-tester success TestRunner PASS
tedd_an/TestRunner_sco-tester success TestRunner PASS
tedd_an/TestRunner_ioctl-tester success TestRunner PASS
tedd_an/TestRunner_mesh-tester success TestRunner PASS
tedd_an/TestRunner_smp-tester success TestRunner PASS
tedd_an/TestRunner_userchan-tester success TestRunner PASS
tedd_an/IncrementalBuild success Incremental Build PASS

Commit Message

K, Kiran June 28, 2023, 11:39 a.m. UTC 
Hardware variant for GalePeak core (CNVi) is added.

Signed-off-by: Kiran K <kiran.k@intel.com>
---
 drivers/bluetooth/btintel.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Paul Menzel June 28, 2023, 11:34 a.m. UTC | #1 
Dear Kiran,


Thank you for your patch.

Am 28.06.23 um 13:39 schrieb Kiran K:
> Hardware variant for GalePeak core (CNVi) is added.

The code names are officially spelled with a space, I believe: Gale Peak.

Maybe also mention 0x1c.

> Signed-off-by: Kiran K <kiran.k@intel.com>
> ---
>   drivers/bluetooth/btintel.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index dd1e48808ee2..f4d096639080 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -480,6 +480,7 @@ static int btintel_version_info_tlv(struct hci_dev *hdev,
>   	case 0x18:	/* Slr */
>   	case 0x19:	/* Slr-F */
>   	case 0x1b:      /* Mgr */
> +	case 0x1c:	/* GaP */

Why not add the full name in the comment? Maybe: Gale Peak (GaP).

>   		break;
>   	default:
>   		bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)",
> @@ -2648,6 +2649,7 @@ static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant)
>   	case 0x18:
>   	case 0x19:
>   	case 0x1b:
> +	case 0x1c:
>   		hci_set_msft_opcode(hdev, 0xFC1E);
>   		break;
>   	default:
> @@ -2862,6 +2864,7 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>   	case 0x18:
>   	case 0x19:
>   	case 0x1b:
> +	case 0x1c:
>   		/* Display version information of TLV type */
>   		btintel_version_info_tlv(hdev, &ver_tlv);
>   


Kind regards,

Paul
K, Kiran June 28, 2023, 11:56 a.m. UTC | #2 
Hi Paul,

Thanks for the comments.

> 
> Dear Kiran,
> 
> 
> Thank you for your patch.
> 
> Am 28.06.23 um 13:39 schrieb Kiran K:
> > Hardware variant for GalePeak core (CNVi) is added.
> 
> The code names are officially spelled with a space, I believe: Gale Peak.
> 
> Maybe also mention 0x1c.

I will fix it in V2 version of patch.
> 
> > Signed-off-by: Kiran K <kiran.k@intel.com>
> > ---
> >   drivers/bluetooth/btintel.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> > index dd1e48808ee2..f4d096639080 100644
> > --- a/drivers/bluetooth/btintel.c
> > +++ b/drivers/bluetooth/btintel.c
> > @@ -480,6 +480,7 @@ static int btintel_version_info_tlv(struct hci_dev
> *hdev,
> >   	case 0x18:	/* Slr */
> >   	case 0x19:	/* Slr-F */
> >   	case 0x1b:      /* Mgr */
> > +	case 0x1c:	/* GaP */
> 
> Why not add the full name in the comment? Maybe: Gale Peak (GaP).
Ack.

> >   	case 0x1b:
> > +	case 0x1c:
> >   		/* Display version information of TLV type */
> >   		btintel_version_info_tlv(hdev, &ver_tlv);
> >
> 
> 
> Kind regards,
> 
> Paul

Regards,
Kiran
bluez.test.bot@gmail.com June 28, 2023, 12:01 p.m. UTC | #3 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=760911

---Test result---

Test Summary:
CheckPatch                    PASS      0.79 seconds
GitLint                       PASS      0.39 seconds
SubjectPrefix                 PASS      0.14 seconds
BuildKernel                   PASS      39.30 seconds
CheckAllWarning               PASS      42.86 seconds
CheckSparse                   PASS      48.51 seconds
CheckSmatch                   PASS      132.21 seconds
BuildKernel32                 PASS      37.94 seconds
TestRunnerSetup               PASS      539.07 seconds
TestRunner_l2cap-tester       PASS      20.30 seconds
TestRunner_iso-tester         PASS      28.33 seconds
TestRunner_bnep-tester        PASS      7.13 seconds
TestRunner_mgmt-tester        PASS      149.78 seconds
TestRunner_rfcomm-tester      PASS      10.86 seconds
TestRunner_sco-tester         PASS      10.08 seconds
TestRunner_ioctl-tester       PASS      11.76 seconds
TestRunner_mesh-tester        PASS      8.97 seconds
TestRunner_smp-tester         PASS      10.19 seconds
TestRunner_userchan-tester    PASS      7.29 seconds
IncrementalBuild              PASS      35.70 seconds



---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz June 28, 2023, 7:40 p.m. UTC | #4 
Hi Kiran,

On Wed, Jun 28, 2023 at 4:57 AM K, Kiran <kiran.k@intel.com> wrote:
>
> Hi Paul,
>
> Thanks for the comments.
>
> >
> > Dear Kiran,
> >
> >
> > Thank you for your patch.
> >
> > Am 28.06.23 um 13:39 schrieb Kiran K:
> > > Hardware variant for GalePeak core (CNVi) is added.
> >
> > The code names are officially spelled with a space, I believe: Gale Peak.
> >
> > Maybe also mention 0x1c.
>
> I will fix it in V2 version of patch.
> >
> > > Signed-off-by: Kiran K <kiran.k@intel.com>
> > > ---
> > >   drivers/bluetooth/btintel.c | 3 +++
> > >   1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> > > index dd1e48808ee2..f4d096639080 100644
> > > --- a/drivers/bluetooth/btintel.c
> > > +++ b/drivers/bluetooth/btintel.c
> > > @@ -480,6 +480,7 @@ static int btintel_version_info_tlv(struct hci_dev
> > *hdev,
> > >     case 0x18:      /* Slr */
> > >     case 0x19:      /* Slr-F */
> > >     case 0x1b:      /* Mgr */
> > > +   case 0x1c:      /* GaP */
> >
> > Why not add the full name in the comment? Maybe: Gale Peak (GaP).
> Ack.

I think it is about time to introduce proper definitions, or use an
enum, for these values. It would be also great to have btmon decoding
these values so you can include a HCI trace in the patch description.

> > >     case 0x1b:
> > > +   case 0x1c:
> > >             /* Display version information of TLV type */
> > >             btintel_version_info_tlv(hdev, &ver_tlv);
> > >
> >
> >
> > Kind regards,
> >
> > Paul
>
> Regards,
> Kiran
diff mbox series

Patch

diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index dd1e48808ee2..f4d096639080 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -480,6 +480,7 @@  static int btintel_version_info_tlv(struct hci_dev *hdev,
 	case 0x18:	/* Slr */
 	case 0x19:	/* Slr-F */
 	case 0x1b:      /* Mgr */
+	case 0x1c:	/* GaP */
 		break;
 	default:
 		bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)",
@@ -2648,6 +2649,7 @@  static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant)
 	case 0x18:
 	case 0x19:
 	case 0x1b:
+	case 0x1c:
 		hci_set_msft_opcode(hdev, 0xFC1E);
 		break;
 	default:
@@ -2862,6 +2864,7 @@  static int btintel_setup_combined(struct hci_dev *hdev)
 	case 0x18:
 	case 0x19:
 	case 0x1b:
+	case 0x1c:
 		/* Display version information of TLV type */
 		btintel_version_info_tlv(hdev, &ver_tlv);