| Message ID | 20230726142817.20504-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [net-next] Bluetooth: Remove unused declaration amp_read_loc_info() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=769739 ---Test result--- Test Summary: CheckPatch PASS 0.66 seconds GitLint PASS 0.34 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 32.41 seconds CheckAllWarning PASS 35.17 seconds CheckSparse PASS 40.40 seconds CheckSmatch PASS 109.71 seconds BuildKernel32 PASS 31.02 seconds TestRunnerSetup PASS 473.12 seconds TestRunner_l2cap-tester PASS 22.45 seconds TestRunner_iso-tester PASS 40.68 seconds TestRunner_bnep-tester PASS 10.23 seconds TestRunner_mgmt-tester PASS 213.42 seconds TestRunner_rfcomm-tester PASS 15.48 seconds TestRunner_sco-tester PASS 16.44 seconds TestRunner_ioctl-tester PASS 17.36 seconds TestRunner_mesh-tester PASS 12.89 seconds TestRunner_smp-tester PASS 13.92 seconds TestRunner_userchan-tester PASS 10.79 seconds IncrementalBuild PASS 29.27 seconds --- Regards, Linux Bluetooth
Dear YueHaibing, Thank you very much for your patch. Am 26.07.23 um 16:28 schrieb YueHaibing: > This is never used, so remove it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Should your name be spelled with a space: Yue Haibing? $ git config --global user.name "Yue Haibing" $ git commit --amend --author="Yue Haibing <yuehaibing@huawei.com>" > --- > net/bluetooth/amp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h > index 832764dfbfb3..97c87abd129f 100644 > --- a/net/bluetooth/amp.h > +++ b/net/bluetooth/amp.h > @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr, > > int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type); > > -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr); Was it never implemented, or just forgotten to be removed? > void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle); > void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr); > void amp_read_loc_assoc_final_data(struct hci_dev *hdev, Kind regards, Paul
On 2023/7/26 23:11, Paul Menzel wrote: > Dear YueHaibing, > > > Thank you very much for your patch. > > Am 26.07.23 um 16:28 schrieb YueHaibing: >> This is never used, so remove it. >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Should your name be spelled with a space: Yue Haibing? > > $ git config --global user.name "Yue Haibing" > $ git commit --amend --author="Yue Haibing <yuehaibing@huawei.com>" Thanks，will fix this. >> --- >> net/bluetooth/amp.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h >> index 832764dfbfb3..97c87abd129f 100644 >> --- a/net/bluetooth/amp.h >> +++ b/net/bluetooth/amp.h >> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr, >> int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type); >> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr); > > Was it never implemented, or just forgotten to be removed? This is introduce in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc") and never implemented. I will update this to commit message. > >> void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle); >> void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr); >> void amp_read_loc_assoc_final_data(struct hci_dev *hdev, > > > Kind regards, > > Paul > > .
diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h index 832764dfbfb3..97c87abd129f 100644 --- a/net/bluetooth/amp.h +++ b/net/bluetooth/amp.h @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr, int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type); -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr); void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle); void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr); void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
This is never used, so remove it. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- net/bluetooth/amp.h | 1 - 1 file changed, 1 deletion(-)