| Message ID | 20230729004552.1422547-2-lukasz.rymanowski@codecoup.pl (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 86a4015659e3ed25bcae01a0ca1c0ba5d655131f |
| Headers | show |
| Series | Couple of improvements to btmon | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | warning | WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #88: < HCI Command: LE Remove Isochronous Data Path (0x08|0x006f) plen 3 #1061 139.246292 WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) #122: FILE: monitor/bt.h:2868: +} __attribute__ ((packed)); /github/workspace/src/src/13332856.patch total: 0 errors, 2 warnings, 21 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13332856.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 5: B1 Line exceeds max length (139>80): "< HCI Command: LE Remove Isochronous Data Path (0x08|0x006f) plen 3 #1061 139.246292" 8: B1 Line exceeds max length (139>80): "> HCI Event: Command Complete (0x0e) plen 6 #1062 139.246954" 15: B1 Line exceeds max length (139>80): "< HCI Command: LE Remove Isochronous Data Path (0x08|0x006f) plen 3 #1061 139.246292" 19: B1 Line exceeds max length (139>80): "> HCI Event: Command Complete (0x0e) plen 6 #1062 139.246954" |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3602:52: warning: array of flexible structuresmonitor/bt.h:3590:40: warning: array of flexible structuresmonitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3602:52: warning: array of flexible structuresmonitor/bt.h:3590:40: warning: array of flexible structuresmonitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3602:52: warning: array of flexible structuresmonitor/bt.h:3590:40: warning: array of flexible structuresmonitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3602:52: warning: array of flexible structuresmonitor/bt.h:3590:40: warning: array of flexible structures |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | warning | ScanBuild: monitor/packet.c:12426:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull' memcpy(tx, tv, sizeof(*tv)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=770766
---Test result---
Test Summary:
CheckPatch FAIL 2.82 seconds
GitLint FAIL 1.85 seconds
BuildEll PASS 34.16 seconds
BluezMake PASS 1217.85 seconds
MakeCheck PASS 13.10 seconds
MakeDistcheck PASS 199.29 seconds
CheckValgrind PASS 313.32 seconds
CheckSmatch WARNING 452.23 seconds
bluezmakeextell PASS 133.58 seconds
IncrementalBuild PASS 5272.12 seconds
ScanBuild WARNING 1463.29 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,1/5] monitor: Fix decoding Command Complete for Remove ISO Data path
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#88:
< HCI Command: LE Remove Isochronous Data Path (0x08|0x006f) plen 3 #1061 139.246292
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#122: FILE: monitor/bt.h:2868:
+} __attribute__ ((packed));
/github/workspace/src/src/13332856.patch total: 0 errors, 2 warnings, 21 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13332856.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[BlueZ,3/5] monitor/ll: Add support for connection parameter command.
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#141: FILE: monitor/bt.h:111:
+} __attribute__ ((packed));
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#157: FILE: monitor/bt.h:127:
+} __attribute__ ((packed));
/github/workspace/src/src/13332857.patch total: 0 errors, 2 warnings, 110 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13332857.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[BlueZ,4/5] monitor: Add support to decode le read ISO link quality
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#88:
> HCI Event: Command Complete (0x0e) plen 34 #14 24.982811
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#116: FILE: monitor/bt.h:2921:
+} __attribute__ ((packed));
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#128: FILE: monitor/bt.h:2933:
+} __attribute__ ((packed));
WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#141: FILE: monitor/packet.c:8949:
+static void le_read_iso_link_quality_cmd(uint16_t index, const void *data, uint8_t size)
WARNING:LONG_LINE: line length of 96 exceeds 80 columns
#148: FILE: monitor/packet.c:8956:
+static void status_le_read_iso_link_quality_rsp(uint16_t index, const void *data, uint8_t size)
/github/workspace/src/src/13332858.patch total: 0 errors, 5 warnings, 74 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13332858.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,1/5] monitor: Fix decoding Command Complete for Remove ISO Data path
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
5: B1 Line exceeds max length (139>80): "< HCI Command: LE Remove Isochronous Data Path (0x08|0x006f) plen 3 #1061 139.246292"
8: B1 Line exceeds max length (139>80): "> HCI Event: Command Complete (0x0e) plen 6 #1062 139.246954"
15: B1 Line exceeds max length (139>80): "< HCI Command: LE Remove Isochronous Data Path (0x08|0x006f) plen 3 #1061 139.246292"
19: B1 Line exceeds max length (139>80): "> HCI Event: Command Complete (0x0e) plen 6 #1062 139.246954"
[BlueZ,3/5] monitor/ll: Add support for connection parameter command.
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T3 Title has trailing punctuation (.): "[BlueZ,3/5] monitor/ll: Add support for connection parameter command."
[BlueZ,4/5] monitor: Add support to decode le read ISO link quality
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
5: B1 Line exceeds max length (139>80): " > HCI Event: Command Complete (0x0e) plen 34 #14 24.982811"
[BlueZ,5/5] monitor: Add parsing Service Data of UUID 128
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
5: B3 Line contains hard tab characters (\t): " Unknown EIR field 0x21: 3a048f2ba97ea6ae1b49c619e973a4a701480d130d"
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3602:52: warning: array of flexible structuresmonitor/bt.h:3590:40: warning: array of flexible structuresmonitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3602:52: warning: array of flexible structuresmonitor/bt.h:3590:40: warning: array of flexible structuresmonitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3602:52: warning: array of flexible structuresmonitor/bt.h:3590:40: warning: array of flexible structuresmonitor/pac
ket.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3602:52: warning: array of flexible structuresmonitor/bt.h:3590:40: warning: array of flexible structures
##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
monitor/packet.c:12426:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull'
memcpy(tx, tv, sizeof(*tv));
^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
---
Regards,
Linux Bluetooth
diff --git a/monitor/bt.h b/monitor/bt.h index b60263fa0..fcc5478bf 100644 --- a/monitor/bt.h +++ b/monitor/bt.h @@ -2862,6 +2862,11 @@ struct bt_hci_cmd_le_remove_iso_path { uint8_t direction; } __attribute__ ((packed)); +struct bt_hci_rsp_le_remove_iso_path { + uint8_t status; + uint16_t handle; +} __attribute__ ((packed)); + #define BT_HCI_CMD_LE_ISO_TX_TEST 0x2070 #define BT_HCI_BIT_LE_ISO_TX_TEST BT_HCI_CMD_BIT(43, 5) diff --git a/monitor/packet.c b/monitor/packet.c index f581a8e72..c7c0308db 100644 --- a/monitor/packet.c +++ b/monitor/packet.c @@ -9871,7 +9871,9 @@ static const struct opcode_data opcode_table[] = { "LE Remove Isochronous Data Path", le_remove_iso_path_cmd, sizeof(struct bt_hci_cmd_le_remove_iso_path), - true, status_rsp, 1, true }, + true, status_handle_rsp, + sizeof(struct bt_hci_rsp_le_remove_iso_path), + true }, { BT_HCI_CMD_LE_ISO_TX_TEST, BT_HCI_BIT_LE_ISO_TX_TEST, "LE Isochronous Transmit Test", NULL, 0, false },
Before < HCI Command: LE Remove Isochronous Data Path (0x08|0x006f) plen 3 #1061 139.246292 Connection Handle: 96 Data Path Direction: Output (Controller to Host) (0x01) > HCI Event: Command Complete (0x0e) plen 6 #1062 139.246954 LE Remove Isochronous Data Path (0x08|0x006f) ncmd 1 invalid packet size 00 60 00 After patch < HCI Command: LE Remove Isochronous Data Path (0x08|0x006f) plen 3 #1061 139.246292 Connection Handle: 96 Data Path Direction: 0x01 Input (Host to Controller) > HCI Event: Command Complete (0x0e) plen 6 #1062 139.246954 LE Remove Isochronous Data Path (0x08|0x006f) ncmd 1 Status: Success (0x00) Connection handle: 96 --- monitor/bt.h | 5 +++++ monitor/packet.c | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-)