| Message ID | 20230729190945.1427101-1-lukasz.rymanowski@codecoup.pl (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8d60b555e8e18992348662a6d232cba9d19178aa |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 5: B3 Line contains hard tab characters (\t): " Unknown EIR field 0x21: 3a048f2ba97ea6ae1b49c619e973a4a701480d130d" |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3551:52: warning: array of flexible structuresmonitor/bt.h:3539:40: warning: array of flexible structures |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | warning | ScanBuild: monitor/packet.c:12382:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull' memcpy(tx, tv, sizeof(*tv)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. |
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sat, 29 Jul 2023 21:09:45 +0200 you wrote: > In the advertising report, instead of parsing EIR 0x21 like this: > > Unknown EIR field 0x21: 3a048f2ba97ea6ae1b49c619e973a4a701480d130d > > We can do bit better > > Service Data UUID 128: Vendor specific > Data: 01480d130d > > [...] Here is the summary with links: - [BlueZ,v2,5/5] monitor: Add parsing Service Data of UUID 128 https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8d60b555e8e1 You are awesome, thank you!
diff --git a/monitor/packet.c b/monitor/packet.c index 3031b028f..21e08ccef 100644 --- a/monitor/packet.c +++ b/monitor/packet.c @@ -3997,6 +3997,18 @@ static void print_eir(const uint8_t *eir, uint8_t eir_len, bool le) print_service_data(data, data_len); break; + case BT_EIR_SERVICE_DATA128: + if (data_len <= 16) + break; + + print_field("Service Data UUID 128: %s ", + bt_uuid128_to_str(&data[0])); + + if (data_len > 16) + print_hex_field(" Data", &data[16], + data_len - 16); + + break; case BT_EIR_RANDOM_ADDRESS: if (data_len < 6) break;
In the advertising report, instead of parsing EIR 0x21 like this: Unknown EIR field 0x21: 3a048f2ba97ea6ae1b49c619e973a4a701480d130d We can do bit better Service Data UUID 128: Vendor specific Data: 01480d130d --- monitor/packet.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)