| Message ID | 20230731041229.1429016-1-simon.mikuda@streamunlimited.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | caf7db313e9dbb23365769c5384bd352f697f406 |
| Headers | show |
| Series | [BlueZ,1/2] adapter: Be able to use ConnectDevice for discovered devices | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
[Cc: +Szymon] Dear Simon, Thank you for your patch. In the commit summary, an alternative to “Be able” could be “Allow”. Am 31.07.23 um 06:12 schrieb Simon Mikuda: > This can be useful when you want to specify trasport type for already tra*n*sport > paired device (e.g. use LE transport for dual mode device). Could you please elaborate a little more? Maybe even give an example, how this can be tested? > --- > src/adapter.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/adapter.c b/src/adapter.c > index 2679d4302..17f4a637d 100644 > --- a/src/adapter.c > +++ b/src/adapter.c > @@ -3763,9 +3763,6 @@ static DBusMessage *connect_device(DBusConnection *conn, > if (!bacmp(&addr, BDADDR_ANY)) > return btd_error_invalid_args(msg); > > - if (btd_adapter_find_device(adapter, &addr, addr_type)) > - return btd_error_already_exists(msg); > - > device_connect(adapter, &addr, addr_type, msg); > return NULL; > }
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=771001 ---Test result--- Test Summary: CheckPatch PASS 0.82 seconds GitLint PASS 0.57 seconds BuildEll PASS 28.69 seconds BluezMake PASS 1057.60 seconds MakeCheck PASS 11.91 seconds MakeDistcheck PASS 164.87 seconds CheckValgrind PASS 267.45 seconds CheckSmatch PASS 397.75 seconds bluezmakeextell PASS 118.45 seconds IncrementalBuild PASS 1912.31 seconds ScanBuild PASS 1276.43 seconds --- Regards, Linux Bluetooth
Hi Paul.
Should I submit new patch with fixed commit message text?
For the testing part:
Precondition: have the linux BT adapter (DUT) ready and some remote
device you want to connect to
Steps:
- make remote device discoverable
- scan for devices on DUT: bluetoothctl --> scan on
- wait until the remote device pops out on dbus interface
- connect to the remote device using Adapter1.ConnectDevice
To do this you can use these commands:
LE: gdbus call --system --dest org.bluez --object-path /org/bluez/hci0
--method org.bluez.Adapter1.ConnectDevice "{'Address':
<'00:00:00:00:00:00'>, 'AddressType': <'public'>}"
BR/EDR: gdbus call --system --dest org.bluez --object-path
/org/bluez/hci0 --method org.bluez.Adapter1.ConnectDevice "{'Address':
<'00:00:00:00:00:00'>}"
For example if remote device emits LE advertisements with general
discoverable flag set and the flag "BR/EDR not supported" is NOT set
calling reqeuset Device1.Connect would result connecting on BR/EDR
transport bearer.
BR,
Simon
On 31. 7. 2023 7:43, Paul Menzel wrote:
> [Cc: +Szymon]
>
> Dear Simon,
>
>
> Thank you for your patch. In the commit summary, an alternative to “Be
> able” could be “Allow”.
>
> Am 31.07.23 um 06:12 schrieb Simon Mikuda:
>> This can be useful when you want to specify trasport type for already
>
> tra*n*sport
>
>> paired device (e.g. use LE transport for dual mode device).
>
> Could you please elaborate a little more? Maybe even give an example,
> how this can be tested?
>
>> ---
>> src/adapter.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/src/adapter.c b/src/adapter.c
>> index 2679d4302..17f4a637d 100644
>> --- a/src/adapter.c
>> +++ b/src/adapter.c
>> @@ -3763,9 +3763,6 @@ static DBusMessage
>> *connect_device(DBusConnection *conn,
>> if (!bacmp(&addr, BDADDR_ANY))
>> return btd_error_invalid_args(msg);
>> - if (btd_adapter_find_device(adapter, &addr, addr_type))
>> - return btd_error_already_exists(msg);
>> -
>> device_connect(adapter, &addr, addr_type, msg);
>> return NULL;
>> }
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 31 Jul 2023 06:12:28 +0200 you wrote: > This can be useful when you want to specify trasport type for already > paired device (e.g. use LE transport for dual mode device). > --- > src/adapter.c | 3 --- > 1 file changed, 3 deletions(-) Here is the summary with links: - [BlueZ,1/2] adapter: Be able to use ConnectDevice for discovered devices https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=caf7db313e9d - [BlueZ,2/2] adapter: Update ConnectDevice documentation https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=255ef572ca76 You are awesome, thank you!
diff --git a/src/adapter.c b/src/adapter.c index 2679d4302..17f4a637d 100644 --- a/src/adapter.c +++ b/src/adapter.c @@ -3763,9 +3763,6 @@ static DBusMessage *connect_device(DBusConnection *conn, if (!bacmp(&addr, BDADDR_ANY)) return btd_error_invalid_args(msg); - if (btd_adapter_find_device(adapter, &addr, addr_type)) - return btd_error_already_exists(msg); - device_connect(adapter, &addr, addr_type, msg); return NULL; }