| Message ID | 20230804215733.1049271-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9665025cc042db2ba2d3b95ff8f0794c9826311d |
| Headers | show |
| Series | [BlueZ] iso-tester: Fix test ISO Connect2 CIG 0x01 - Success/Invalid | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=773285 ---Test result--- Test Summary: CheckPatch PASS 0.47 seconds GitLint PASS 0.32 seconds BuildEll PASS 33.67 seconds BluezMake PASS 1007.74 seconds MakeCheck PASS 12.90 seconds MakeDistcheck PASS 188.31 seconds CheckValgrind PASS 301.79 seconds CheckSmatch PASS 406.93 seconds bluezmakeextell PASS 124.09 seconds IncrementalBuild PASS 828.35 seconds ScanBuild PASS 1284.84 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Fri, 4 Aug 2023 14:57:33 -0700 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > This test shall succeed rather than fail as this appears to be a bug in > the kernel code preventing Set CIG Parameters to work properly when > there are concurrent tasks only one CIS is being programmed. > --- > tools/iso-tester.c | 29 +++-------------------------- > 1 file changed, 3 insertions(+), 26 deletions(-) Here is the summary with links: - [BlueZ] iso-tester: Fix test ISO Connect2 CIG 0x01 - Success/Invalid https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9665025cc042 You are awesome, thank you!
diff --git a/tools/iso-tester.c b/tools/iso-tester.c index bbf959420488..9b9716e06bdb 100644 --- a/tools/iso-tester.c +++ b/tools/iso-tester.c @@ -2402,29 +2402,6 @@ static void test_connect2_seq(const void *test_data) setup_connect(data, 0, iso_connect2_seq_cb); } -static void test_connect2_nodefer(const void *test_data) -{ - struct test_data *data = tester_get_data(); - int sk, err; - - /* Second connect() shall fail, because CIG is then busy, - * but the first connect() shall succeed. - */ - setup_connect(data, 0, iso_connect_cb); - - sk = create_iso_sock(data); - if (sk < 0) { - tester_test_failed(); - return; - } - - err = connect_iso_sock(data, 1, sk); - if (err != -EINVAL) - tester_test_failed(); - - close(sk); -} - static gboolean iso_connect_close_cb(GIOChannel *io, GIOCondition cond, gpointer user_data) { @@ -2697,13 +2674,13 @@ int main(int argc, char *argv[]) test_iso("ISO Connect Wait Close - Success", &connect_16_2_1, setup_powered, test_connect_wait_close); - test_iso2("ISO Defer Connect2 CIG 0x01 - Success", &defer_1_16_2_1, + test_iso2("ISO Connect2 CIG 0x01 - Success", &connect_1_16_2_1, setup_powered, test_connect2); - test_iso2("ISO Connect2 CIG 0x01 - Success/Invalid", &connect_1_16_2_1, + test_iso2("ISO Defer Connect2 CIG 0x01 - Success", &defer_1_16_2_1, setup_powered, - test_connect2_nodefer); + test_connect2); test_iso("ISO Defer Send - Success", &connect_16_2_1_defer_send, setup_powered,
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> This test shall succeed rather than fail as this appears to be a bug in the kernel code preventing Set CIG Parameters to work properly when there are concurrent tasks only one CIS is being programmed. --- tools/iso-tester.c | 29 +++-------------------------- 1 file changed, 3 insertions(+), 26 deletions(-)