| Message ID | 20230809202724.15429-2-bart.philips@inspiro.nl (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8bf3a4a265bb199e21735639c57f1f652e5b8d45 |
| Headers | show |
| Series | fix writes to attributes of size 512 | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING src/shared/gatt-server.c:276:25: warning: Variable length array is used.src/shared/gatt-server.c:619:25: warning: Variable length array is used.src/shared/gatt-server.c:718:25: warning: Variable length array is used.src/shared/gatt-server.c:276:25: warning: Variable length array is used.src/shared/gatt-server.c:619:25: warning: Variable length array is used.src/shared/gatt-server.c:718:25: warning: Variable length array is used.src/shared/gatt-server.c:276:25: warning: Variable length array is used.src/shared/gatt-server.c:619:25: warning: Variable length array is used.src/shared/gatt-server.c:718:25: warning: Variable length array is used. |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=774683 ---Test result--- Test Summary: CheckPatch PASS 0.38 seconds GitLint PASS 0.26 seconds BuildEll PASS 35.08 seconds BluezMake PASS 1243.06 seconds MakeCheck PASS 13.84 seconds MakeDistcheck PASS 204.06 seconds CheckValgrind PASS 330.63 seconds CheckSmatch WARNING 454.78 seconds bluezmakeextell PASS 135.61 seconds IncrementalBuild PASS 1067.75 seconds ScanBuild PASS 1450.74 seconds Details ############################## Test: CheckSmatch - WARNING Desc: Run smatch tool with source Output: src/shared/gatt-server.c:276:25: warning: Variable length array is used.src/shared/gatt-server.c:619:25: warning: Variable length array is used.src/shared/gatt-server.c:718:25: warning: Variable length array is used.src/shared/gatt-server.c:276:25: warning: Variable length array is used.src/shared/gatt-server.c:619:25: warning: Variable length array is used.src/shared/gatt-server.c:718:25: warning: Variable length array is used.src/shared/gatt-server.c:276:25: warning: Variable length array is used.src/shared/gatt-server.c:619:25: warning: Variable length array is used.src/shared/gatt-server.c:718:25: warning: Variable length array is used. --- Regards, Linux Bluetooth
diff --git a/src/shared/gatt-server.c b/src/shared/gatt-server.c index 0512d06f6..c7ce3ec1f 100644 --- a/src/shared/gatt-server.c +++ b/src/shared/gatt-server.c @@ -846,7 +846,7 @@ static void write_cb(struct bt_att_chan *chan, uint8_t opcode, const void *pdu, DBG(server, "Write %s - handle: 0x%04x", (opcode == BT_ATT_OP_WRITE_REQ) ? "Req" : "Cmd", handle); - ecode = check_length(length, 0); + ecode = check_length(length - 2, 0); if (ecode) goto error; @@ -1333,7 +1333,7 @@ static void prep_write_cb(struct bt_att_chan *chan, uint8_t opcode, DBG(server, "Prep Write Req - handle: 0x%04x", handle); - ecode = check_length(length, offset); + ecode = check_length(length - 4, offset); if (ecode) goto error;