| Message ID | 20230831220137.1164891-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d06b912df5abbf1cc046389c36726edd28b373d3 |
| Headers | show |
| Series | [BlueZ] bap: Fix not always calling bap_io_close on disconnect | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=780965 ---Test result--- Test Summary: CheckPatch PASS 0.51 seconds GitLint PASS 0.35 seconds BuildEll PASS 27.49 seconds BluezMake PASS 1016.78 seconds MakeCheck PASS 12.13 seconds MakeDistcheck PASS 161.16 seconds CheckValgrind PASS 261.19 seconds CheckSmatch PASS 347.49 seconds bluezmakeextell PASS 105.31 seconds IncrementalBuild PASS 849.83 seconds ScanBuild PASS 1090.50 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 31 Aug 2023 15:01:37 -0700 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > bap_io_disconnected was getting registered for all links while > connecting which prevented bap_io_close to be called when ISO socket is > disconnected thus the cig_active flag will remain set preventing the IO > to be recreated. > > [...] Here is the summary with links: - [BlueZ] bap: Fix not always calling bap_io_close on disconnect https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d06b912df5ab You are awesome, thank you!
diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c index 001a47bdc47b..9634ae4fc6c3 100644 --- a/profiles/audio/bap.c +++ b/profiles/audio/bap.c @@ -1936,6 +1936,8 @@ static void bap_connecting(struct bt_bap_stream *stream, bool state, int fd, if (!ep->io) { io = g_io_channel_unix_new(fd); + ep->io_id = g_io_add_watch(io, G_IO_HUP | G_IO_ERR | G_IO_NVAL, + bap_io_disconnected, ep); ep->io = io; } else io = ep->io;
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> bap_io_disconnected was getting registered for all links while connecting which prevented bap_io_close to be called when ISO socket is disconnected thus the cig_active flag will remain set preventing the IO to be recreated. --- profiles/audio/bap.c | 2 ++ 1 file changed, 2 insertions(+)