[1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

Commit Message

Vlad Pruteanu Sept. 7, 2023, 9:30 a.m. UTC

Currently the CIS bit that can be set by the host is set for any device
that has CIS or BIS support. In reality, devices that support BIS may not
allow that bit to be set and so, the HCI bring up fails for them.

This commit fixes this by only setting the bit for CIS capable devices.
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

[e-mail] Sept. 7, 2023, 4:45 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=782238

---Test result---

Test Summary:
CheckPatch                    FAIL      1.00 seconds
GitLint                       PASS      0.34 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      43.07 seconds
CheckAllWarning               PASS      46.19 seconds
CheckSparse                   PASS      52.59 seconds
CheckSmatch                   PASS      142.30 seconds
BuildKernel32                 PASS      42.02 seconds
TestRunnerSetup               PASS      630.56 seconds
TestRunner_l2cap-tester       PASS      35.90 seconds
TestRunner_iso-tester         PASS      83.27 seconds
TestRunner_bnep-tester        PASS      14.64 seconds
TestRunner_mgmt-tester        PASS      280.46 seconds
TestRunner_rfcomm-tester      PASS      22.30 seconds
TestRunner_sco-tester         PASS      24.38 seconds
TestRunner_ioctl-tester       PASS      23.92 seconds
TestRunner_mesh-tester        PASS      17.77 seconds
TestRunner_smp-tester         PASS      18.96 seconds
TestRunner_userchan-tester    PASS      15.15 seconds
IncrementalBuild              PASS      38.71 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 0 checks, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13376524.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth

Patch

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ec4dfc4c5749..f09c5812c247 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4264,7 +4264,7 @@  static int hci_le_set_host_feature_sync(struct hci_dev *hdev)
 {
 	struct hci_cp_le_set_host_feature cp;
 
-	if (!iso_capable(hdev))
+	if (!cis_capable(hdev))
 		return 0;
 
 	memset(&cp, 0, sizeof(cp));