Bluetooth: hci_codec: Fix leaking content of local_codecs

Commit Message

Luiz Augusto von Dentz Sept. 15, 2023, 8:24 p.m. UTC

From: Luiz Augusto von Dentz <[e-mail]>

The following memory leak can be observed when the controller supports
codecs which are stored in local_codecs list but the elements are never
freed:

unreferenced object 0xffff88800221d840 (size 32):
  comm "kworker/u3:0", pid 36, jiffies 4294898739 (age 127.060s)
  hex dump (first 32 bytes):
    f8 d3 02 03 80 88 ff ff 80 d8 21 02 80 88 ff ff  ..........!.....
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffffb324f557>] __kmalloc+0x47/0x120
    [<ffffffffb39ef37d>] hci_codec_list_add.isra.0+0x2d/0x160
    [<ffffffffb39ef643>] hci_read_codec_capabilities+0x183/0x270
    [<ffffffffb39ef9ab>] hci_read_supported_codecs+0x1bb/0x2d0
    [<ffffffffb39f162e>] hci_read_local_codecs_sync+0x3e/0x60
    [<ffffffffb39ff1b3>] hci_dev_open_sync+0x943/0x11e0
    [<ffffffffb396d55d>] hci_power_on+0x10d/0x3f0
    [<ffffffffb30c99b4>] process_one_work+0x404/0x800
    [<ffffffffb30ca134>] worker_thread+0x374/0x670
    [<ffffffffb30d9108>] kthread+0x188/0x1c0
    [<ffffffffb304db6b>] ret_from_fork+0x2b/0x50
    [<ffffffffb300206a>] ret_from_fork_asm+0x1a/0x30

Cc: [e-mail]
Fixes: 8961987f3f5f ("Bluetooth: Enumerate local supported codec and cache details")
Signed-off-by: Luiz Augusto von Dentz <[e-mail]>
---
 net/bluetooth/hci_core.c  | 1 +
 net/bluetooth/hci_event.c | 2 ++
 2 files changed, 3 insertions(+)

Comments

[e-mail] Sept. 15, 2023, 9:01 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=784822

---Test result---

Test Summary:
CheckPatch                    PASS      0.91 seconds
GitLint                       PASS      0.37 seconds
SubjectPrefix                 PASS      0.14 seconds
BuildKernel                   PASS      33.48 seconds
CheckAllWarning               WARNING   36.77 seconds
CheckSparse                   WARNING   41.98 seconds
CheckSmatch                   WARNING   116.36 seconds
BuildKernel32                 PASS      32.39 seconds
TestRunnerSetup               PASS      492.52 seconds
TestRunner_l2cap-tester       PASS      29.93 seconds
TestRunner_iso-tester         PASS      49.64 seconds
TestRunner_bnep-tester        PASS      9.88 seconds
TestRunner_mgmt-tester        PASS      225.79 seconds
TestRunner_rfcomm-tester      PASS      15.15 seconds
TestRunner_sco-tester         PASS      18.73 seconds
TestRunner_ioctl-tester       PASS      16.71 seconds
TestRunner_mesh-tester        PASS      12.59 seconds
TestRunner_smp-tester         PASS      13.48 seconds
TestRunner_userchan-tester    PASS      10.36 seconds
IncrementalBuild              PASS      30.54 seconds

Details
##############################
Test: CheckAllWarning - WARNING
Desc: Run linux kernel with all warning enabled
Output:
net/bluetooth/hci_core.c: In function ‘hci_register_dev’:net/bluetooth/hci_core.c:2620:47: warning: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Wformat-truncation=] 2620 |  snprintf(hdev->name, sizeof(hdev->name), "hci%d", id);      |                                               ^~net/bluetooth/hci_core.c:2620:43: note: directive argument in the range [0, 2147483647] 2620 |  snprintf(hdev->name, sizeof(hdev->name), "hci%d", id);      |                                           ^~~~~~~net/bluetooth/hci_core.c:2620:2: note: ‘snprintf’ output between 5 and 14 bytes into a destination of size 8 2620 |  snprintf(hdev->name, sizeof(hdev->name), "hci%d", id);      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):


---
Regards,
Linux Bluetooth

Patch

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index db4f28d68d71..91895bfb6b2d 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -2784,6 +2784,7 @@  void hci_release_dev(struct hci_dev *hdev)
 	hci_conn_params_clear_all(hdev);
 	hci_discovery_filter_clear(hdev);
 	hci_blocked_keys_clear(hdev);
+	hci_codec_list_clear(&hdev->local_codecs);
 	hci_dev_unlock(hdev);
 
 	ida_simple_remove(&hci_index_ida, hdev->id);
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index d532f4c139f9..ee2c418f8e06 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -33,6 +33,7 @@ 
 
 #include "hci_request.h"
 #include "hci_debugfs.h"
+#include "hci_codec.h"
 #include "a2mp.h"
 #include "amp.h"
 #include "smp.h"
@@ -301,6 +302,7 @@  static u8 hci_cc_reset(struct hci_dev *hdev, void *data, struct sk_buff *skb)
 
 	hci_bdaddr_list_clear(&hdev->le_accept_list);
 	hci_bdaddr_list_clear(&hdev->le_resolv_list);
+	hci_codec_list_clear(&hdev->local_codecs);
 
 	return rp->status;
 }