diff mbox series

configure.ac: Add enable_btpclient and enable_mesh for internal ELL

Message ID 20230917165044.40310-1-koba.ko@canonical.com (mailing list archive)
State Superseded
Headers show
Series configure.ac: Add enable_btpclient and enable_mesh for internal ELL | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Koba Ko Sept. 17, 2023, 4:50 p.m. UTC
when enable_external_ell is not specified, confiugre doesn't not check
if enable_btpclient and enable_mesh are enabled.
this causes the internal ELL must be installed.

Signed-off-by: Koba Ko <koba.ko@canonical.com>
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Paul Menzel Sept. 17, 2023, 4:58 p.m. UTC | #1
Dear Koba,


Thank you for your patch. I think you should tag your patch with BlueZ 
in the commit message summary.

Am 17.09.23 um 18:50 schrieb Koba Ko:
> when enable_external_ell is not specified, confiugre doesn't not check

configu*re*

> if enable_btpclient and enable_mesh are enabled.
> this causes the internal ELL must be installed.

It’d be great, if you rephrased the last sentence, as I have a hard time 
to understand it.

> Signed-off-by: Koba Ko <koba.ko@canonical.com>
> ---
>   configure.ac | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4186c3792..9897d36d6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -301,7 +301,8 @@ if (test "${enable_external_ell}" = "yes"); then
>   	AC_SUBST(ELL_CFLAGS)
>   	AC_SUBST(ELL_LIBS)
>   fi
> -if (test "${enable_external_ell}" != "yes"); then
> +if (test "${enable_external_ell}" != "yes" &&
> +		(test "${enable_btpclient}" = "yes" && test "${enable_mesh}" = "yes")); then
>   	if (test ! -f ${srcdir}/ell/ell.h) &&
>   			(test ! -f ${srcdir}/../ell/ell/ell.h); then
>   				AC_MSG_ERROR(ELL source is required or use --enable-external-ell)


Kind regards,

Paul
bluez.test.bot@gmail.com Sept. 17, 2023, 6:32 p.m. UTC | #2
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=785015

---Test result---

Test Summary:
CheckPatch                    PASS      0.37 seconds
GitLint                       PASS      0.30 seconds
BuildEll                      PASS      34.81 seconds
BluezMake                     PASS      1211.62 seconds
MakeCheck                     PASS      13.50 seconds
MakeDistcheck                 PASS      198.92 seconds
CheckValgrind                 PASS      320.07 seconds
CheckSmatch                   PASS      450.83 seconds
bluezmakeextell               PASS      135.07 seconds
IncrementalBuild              PASS      1062.32 seconds
ScanBuild                     PASS      1415.01 seconds



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index 4186c3792..9897d36d6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -301,7 +301,8 @@  if (test "${enable_external_ell}" = "yes"); then
 	AC_SUBST(ELL_CFLAGS)
 	AC_SUBST(ELL_LIBS)
 fi
-if (test "${enable_external_ell}" != "yes"); then
+if (test "${enable_external_ell}" != "yes" &&
+		(test "${enable_btpclient}" = "yes" && test "${enable_mesh}" = "yes")); then
 	if (test ! -f ${srcdir}/ell/ell.h) &&
 			(test ! -f ${srcdir}/../ell/ell/ell.h); then
 				AC_MSG_ERROR(ELL source is required or use --enable-external-ell)