diff mbox series

[BlueZ,1/6] shared/csip: Fix returning invalid data to attribute Size reads

Message ID 20231002231311.3104749-1-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Commit b938b05559d345306486b6badc245b18d88f0ccf
Headers show
Series [BlueZ,1/6] shared/csip: Fix returning invalid data to attribute Size reads | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Luiz Augusto von Dentz Oct. 2, 2023, 11:13 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

The attribute Size value is stored in the size_val not on size member
which represents the attribute object.
---
 src/shared/csip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

bluez.test.bot@gmail.com Oct. 3, 2023, 1:50 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=789421

---Test result---

Test Summary:
CheckPatch                    PASS      2.70 seconds
GitLint                       PASS      7.02 seconds
BuildEll                      PASS      28.76 seconds
BluezMake                     PASS      979.14 seconds
MakeCheck                     PASS      12.63 seconds
MakeDistcheck                 PASS      163.32 seconds
CheckValgrind                 PASS      264.15 seconds
CheckSmatch                   PASS      356.79 seconds
bluezmakeextell               PASS      109.03 seconds
IncrementalBuild              PASS      4989.81 seconds
ScanBuild                     PASS      1092.62 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Oct. 3, 2023, 11:20 p.m. UTC | #2
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon,  2 Oct 2023 16:13:05 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> The attribute Size value is stored in the size_val not on size member
> which represents the attribute object.
> ---
>  src/shared/csip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [BlueZ,1/6] shared/csip: Fix returning invalid data to attribute Size reads
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b938b05559d3
  - [BlueZ,2/6] shared/csip: Fix not requiring encryption
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a1920af6f81f
  - [BlueZ,3/6] shared/csip: Fix not always reading SIRK value
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=65b53b0d3a88
  - [BlueZ,4/6] device: Add btd_device_get_ltk
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c35304f32c42
  - [BlueZ,5/6] csip: Add support for SIRK encryption
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=267bf36d844b
  - [BlueZ,6/6] main.conf: Fix default of CSIS.encrypt
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=954b8e5324fd

You are awesome, thank you!
diff mbox series

Patch

diff --git a/src/shared/csip.c b/src/shared/csip.c
index 04a8d542b390..24d5d6a323bd 100644
--- a/src/shared/csip.c
+++ b/src/shared/csip.c
@@ -291,8 +291,8 @@  static void csis_size_read(struct gatt_db_attribute *attrib,
 	struct bt_csis *csis = user_data;
 	struct iovec iov;
 
-	iov.iov_base = &csis->size;
-	iov.iov_len = sizeof(csis->size);
+	iov.iov_base = &csis->size_val;
+	iov.iov_len = sizeof(csis->size_val);
 
 	gatt_db_attribute_read_result(attrib, id, 0, iov.iov_base,
 							iov.iov_len);