diff mbox series

[BlueZ,v2] mesh: Fix check for active scan when using generic IO

Message ID 20231017002123.43533-1-inga.stotland@gmail.com (mailing list archive)
State Accepted
Commit 0c757e8eeef69ff2b1eefa59e590f171c9fe1c88
Headers show
Series [BlueZ,v2] mesh: Fix check for active scan when using generic IO | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Inga Stotland Oct. 17, 2023, 12:21 a.m. UTC
This modifies the check for an active scan in generic IO:
the bug has been introduced during earlier code refactoring.

Fixes: https://github.com/bluez/bluez/issues/625
---
 mesh/mesh-io-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com Oct. 17, 2023, 2:22 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=793761

---Test result---

Test Summary:
CheckPatch                    PASS      0.57 seconds
GitLint                       PASS      1.14 seconds
BuildEll                      PASS      36.74 seconds
BluezMake                     PASS      1225.66 seconds
MakeCheck                     PASS      14.24 seconds
MakeDistcheck                 PASS      230.61 seconds
CheckValgrind                 PASS      350.93 seconds
CheckSmatch                   PASS      483.93 seconds
bluezmakeextell               PASS      155.13 seconds
IncrementalBuild              PASS      1108.57 seconds
ScanBuild                     PASS      1486.37 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Oct. 17, 2023, 4:40 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Brian Gix <brian.gix@gmail.com>:

On Mon, 16 Oct 2023 17:21:23 -0700 you wrote:
> This modifies the check for an active scan in generic IO:
> the bug has been introduced during earlier code refactoring.
> 
> Fixes: https://github.com/bluez/bluez/issues/625
> ---
>  mesh/mesh-io-generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ,v2] mesh: Fix check for active scan when using generic IO
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0c757e8eeef6

You are awesome, thank you!
diff mbox series

Patch

diff --git a/mesh/mesh-io-generic.c b/mesh/mesh-io-generic.c
index 00932ade7..13a863b48 100644
--- a/mesh/mesh-io-generic.c
+++ b/mesh/mesh-io-generic.c
@@ -781,7 +781,7 @@  static bool recv_register(struct mesh_io *io, const uint8_t *filter,
 	bool already_scanning;
 	bool active = false;
 
-	already_scanning = !l_queue_isempty(io->rx_regs);
+	already_scanning = l_queue_length(io->rx_regs) > 1;
 
 	/* Look for any AD types requiring Active Scanning */
 	if (l_queue_find(io->rx_regs, find_active, NULL))