diff mbox series

[v1,1/5] media: Populate location to qos structure

Message ID 20231020142554.486629-1-kiran.k@intel.com (mailing list archive)
State New, archived
Headers show
Series [v1,1/5] media: Populate location to qos structure | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

K, Kiran Oct. 20, 2023, 2:25 p.m. UTC 
Allow clients to register Location for endpoint.
---
 profiles/audio/media.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Pauli Virtanen Oct. 20, 2023, 3:50 p.m. UTC | #1 
Hi,

pe, 2023-10-20 kello 19:55 +0530, Kiran K kirjoitti:
> Allow clients to register Location for endpoint.
> ---
>  profiles/audio/media.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/profiles/audio/media.c b/profiles/audio/media.c
> index 1d98ac5a1a70..d0520d3216c9 100644
> --- a/profiles/audio/media.c
> +++ b/profiles/audio/media.c
> @@ -1609,6 +1609,10 @@ static int parse_properties(DBusMessageIter *props, const char **uuid,
>  			if (var != DBUS_TYPE_UINT16)
>  				return -EINVAL;
>  			dbus_message_iter_get_basic(&value, &qos->ppd_max);
> +		} else if (strcasecmp(key, "Location") == 0) {
> +			if (var != DBUS_TYPE_UINT32)
> +				return -EINVAL;
> +			dbus_message_iter_get_basic(&value, &qos->location);
>  		}

The name of the key should be "Locations", not "Location", see
doc/org.bluez.MediaEndpoint.rst

>  
>  		dbus_message_iter_next(props);
> @@ -2799,6 +2803,13 @@ static void app_register_endpoint(void *data, void *user_data)
>  		dbus_message_iter_get_basic(&iter, &qos.ppd_min);
>  	}
>  
> +	if (g_dbus_proxy_get_property(proxy, "Location", &iter)) {

Similarly here.

> +		if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_UINT32)
> +			goto fail;
> +
> +		dbus_message_iter_get_basic(&iter, &qos.location);
> +	}
> +
>  	endpoint = media_endpoint_create(app->adapter, app->sender, path, uuid,
>  						delay_reporting, codec,
>  						vendor.cid, vendor.vid, &qos,
bluez.test.bot@gmail.com Oct. 20, 2023, 4:32 p.m. UTC | #2 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=795144

---Test result---

Test Summary:
CheckPatch                    PASS      2.33 seconds
GitLint                       PASS      1.64 seconds
BuildEll                      PASS      28.35 seconds
BluezMake                     PASS      930.45 seconds
MakeCheck                     PASS      11.57 seconds
MakeDistcheck                 PASS      180.89 seconds
CheckValgrind                 PASS      278.11 seconds
CheckSmatch                   PASS      381.00 seconds
bluezmakeextell               PASS      120.14 seconds
IncrementalBuild              PASS      3824.44 seconds
ScanBuild                     PASS      1143.53 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Oct. 20, 2023, 8:50 p.m. UTC | #3 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 20 Oct 2023 19:55:50 +0530 you wrote:
> Allow clients to register Location for endpoint.
> ---
>  profiles/audio/media.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Here is the summary with links:
  - [v1,1/5] media: Populate location to qos structure
    (no matching commit)
  - [v1,2/5] bap: Fix update of sink location value
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5f8323f2aaa3
  - [v1,3/5] bap: Do not set default location for sink and source
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=932e64206069
  - [v1,4/5] bap: Fix reading source codec capabilities
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a564d6a0d533
  - [v1,5/5] media: Parse conext and supported context
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f02e0c8664a6

You are awesome, thank you!
diff mbox series

Patch

diff --git a/profiles/audio/media.c b/profiles/audio/media.c
index 1d98ac5a1a70..d0520d3216c9 100644
--- a/profiles/audio/media.c
+++ b/profiles/audio/media.c
@@ -1609,6 +1609,10 @@  static int parse_properties(DBusMessageIter *props, const char **uuid,
 			if (var != DBUS_TYPE_UINT16)
 				return -EINVAL;
 			dbus_message_iter_get_basic(&value, &qos->ppd_max);
+		} else if (strcasecmp(key, "Location") == 0) {
+			if (var != DBUS_TYPE_UINT32)
+				return -EINVAL;
+			dbus_message_iter_get_basic(&value, &qos->location);
 		}
 
 		dbus_message_iter_next(props);
@@ -2799,6 +2803,13 @@  static void app_register_endpoint(void *data, void *user_data)
 		dbus_message_iter_get_basic(&iter, &qos.ppd_min);
 	}
 
+	if (g_dbus_proxy_get_property(proxy, "Location", &iter)) {
+		if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_UINT32)
+			goto fail;
+
+		dbus_message_iter_get_basic(&iter, &qos.location);
+	}
+
 	endpoint = media_endpoint_create(app->adapter, app->sender, path, uuid,
 						delay_reporting, codec,
 						vendor.cid, vendor.vid, &qos,