| Message ID | 20231107054609.1.I4c7ab22148e168e3cde00f27b89748ff4bc651c2@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: btusb: Return when coredump trigger cmd fails | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=799445 ---Test result--- Test Summary: CheckPatch PASS 0.62 seconds GitLint PASS 0.31 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 27.97 seconds CheckAllWarning PASS 31.30 seconds CheckSparse PASS 35.53 seconds CheckSmatch PASS 98.27 seconds BuildKernel32 PASS 26.39 seconds TestRunnerSetup PASS 414.20 seconds TestRunner_l2cap-tester PASS 23.07 seconds TestRunner_iso-tester PASS 44.26 seconds TestRunner_bnep-tester PASS 7.05 seconds TestRunner_mgmt-tester PASS 171.48 seconds TestRunner_rfcomm-tester PASS 11.08 seconds TestRunner_sco-tester PASS 14.66 seconds TestRunner_ioctl-tester PASS 12.12 seconds TestRunner_mesh-tester PASS 14.57 seconds TestRunner_smp-tester PASS 10.12 seconds TestRunner_userchan-tester PASS 7.48 seconds IncrementalBuild PASS 25.79 seconds --- Regards, Linux Bluetooth
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index b8e9de887b5d..a0359702c0a1 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -3463,8 +3463,11 @@ static void btusb_coredump_qca(struct hci_dev *hdev) struct sk_buff *skb; skb = __hci_cmd_sync(hdev, 0xfc0c, 1, param, HCI_CMD_TIMEOUT); - if (IS_ERR(skb)) + if (IS_ERR(skb)) { bt_dev_err(hdev, "%s: triggle crash failed (%ld)", __func__, PTR_ERR(skb)); + return; + } + kfree_skb(skb); }
Avoid freeing NULL skb when hci command fails. Fixes: 20981ce2d5a5 ("Bluetooth: btusb: Add WCN6855 devcoredump support") Signed-off-by: Manish Mandlik <mmandlik@google.com> --- drivers/bluetooth/btusb.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)