[RESEND] Bluetooth: btusb: Don't suspend when there are connections

Commit Message

Luiz Augusto von Dentz Nov. 21, 2023, 9:31 p.m. UTC

From: Luiz Augusto von Dentz <[e-mail]>

This checks if there are connections before suspending since that may
disrupt the connections making it stop receiving any data if remote
wakeup is not enabled.

Signed-off-by: Luiz Augusto von Dentz <[e-mail]>
---
 drivers/bluetooth/btusb.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

[e-mail] Nov. 21, 2023, 10:32 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=803013

---Test result---

Test Summary:
CheckPatch                    PASS      0.60 seconds
GitLint                       PASS      0.31 seconds
SubjectPrefix                 PASS      0.11 seconds
BuildKernel                   PASS      28.22 seconds
CheckAllWarning               PASS      30.62 seconds
CheckSparse                   PASS      36.15 seconds
CheckSmatch                   PASS      100.30 seconds
BuildKernel32                 PASS      27.14 seconds
TestRunnerSetup               PASS      416.53 seconds
TestRunner_l2cap-tester       PASS      23.34 seconds
TestRunner_iso-tester         PASS      42.66 seconds
TestRunner_bnep-tester        PASS      6.86 seconds
TestRunner_mgmt-tester        PASS      165.18 seconds
TestRunner_rfcomm-tester      PASS      10.83 seconds
TestRunner_sco-tester         PASS      15.69 seconds
TestRunner_ioctl-tester       PASS      12.07 seconds
TestRunner_mesh-tester        PASS      9.04 seconds
TestRunner_smp-tester         PASS      9.86 seconds
TestRunner_userchan-tester    PASS      7.35 seconds
IncrementalBuild              PASS      25.95 seconds



---
Regards,
Linux Bluetooth

[e-mail] Nov. 22, 2023, 5:40 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Tue, 21 Nov 2023 16:31:59 -0500 you wrote:
> From: Luiz Augusto von Dentz <[e-mail]>
> 
> This checks if there are connections before suspending since that may
> disrupt the connections making it stop receiving any data if remote
> wakeup is not enabled.
> 
> Signed-off-by: Luiz Augusto von Dentz <[e-mail]>
> 
> [...]

Here is the summary with links:
  - [RESEND] Bluetooth: btusb: Don't suspend when there are connections
    https://git.kernel.org/bluetooth/bluetooth-next/c/d4a9d62c7f82

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index b8e9de887b5d..0926e4451802 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -4629,6 +4629,10 @@  static int btusb_suspend(struct usb_interface *intf, pm_message_t message)
 
 	BT_DBG("intf %p", intf);
 
+	/* Don't suspend if there are connections */
+	if (hci_conn_count(data->hdev))
+		return -EBUSY;
+
 	if (data->suspend_count++)
 		return 0;