| Message ID | 20231212190531.BlueZ.1.Ia938c97b56083995e9f6bbba445a01b4cb4de0c9@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d206ab94a79e0c6c96265fca1155caea18405a73 |
| Headers | show |
| Series | [BlueZ] monitor: add Qualcomm and Mediatek MSFT opcodes | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1860:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3606:52: warning: array of flexible structuresmonitor/bt.h:3594:40: warning: array of flexible structures |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=809171 ---Test result--- Test Summary: CheckPatch PASS 0.48 seconds GitLint PASS 0.35 seconds BuildEll PASS 23.74 seconds BluezMake PASS 706.11 seconds MakeCheck PASS 11.87 seconds MakeDistcheck PASS 156.79 seconds CheckValgrind PASS 215.04 seconds CheckSmatch WARNING 319.08 seconds bluezmakeextell PASS 100.50 seconds IncrementalBuild PASS 645.16 seconds ScanBuild PASS 913.01 seconds Details ############################## Test: CheckSmatch - WARNING Desc: Run smatch tool with source Output: monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1860:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3606:52: warning: array of flexible structuresmonitor/bt.h:3594:40: warning: array of flexible structures --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 12 Dec 2023 19:05:31 +0800 you wrote: > From: Archie Pusaka <apusaka@chromium.org> > > Qualcomm and Mediatek has 0xfd70 and 0xfd30 for their MSFT opcodes, > respectively. > > Signed-off-by: Archie Pusaka <apusaka@chromium.org> > Reviewed-by: Hsin-chen Chuang <chharry@google.com> > > [...] Here is the summary with links: - [BlueZ] monitor: add Qualcomm and Mediatek MSFT opcodes https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d206ab94a79e You are awesome, thank you!
diff --git a/monitor/packet.c b/monitor/packet.c index b06f8a5d38..42e711cafa 100644 --- a/monitor/packet.c +++ b/monitor/packet.c @@ -4286,10 +4286,26 @@ void packet_monitor(struct timeval *tv, struct ucred *cred, */ index_list[index].msft_opcode = 0xFC1E; break; + case 29: + /* + * Qualcomm controllers that support the + * Microsoft vendor extensions are using + * 0xFD70 for VsMsftOpCode. + */ + index_list[index].msft_opcode = 0xFD70; + break; + case 70: + /* + * Mediatek controllers that support the + * Microsoft vendor extensions are using + * 0xFD30 for VsMsftOpCode. + */ + index_list[index].msft_opcode = 0xFD30; + break; case 93: /* * Realtek controllers that support the - * Microsoft vendor extenions are using + * Microsoft vendor extensions are using * 0xFCF0 for VsMsftOpCode. */ index_list[index].msft_opcode = 0xFCF0; @@ -4298,7 +4314,7 @@ void packet_monitor(struct timeval *tv, struct ucred *cred, /* * Emulator controllers use Linux Foundation as * manufacturer and support the - * Microsoft vendor extenions using + * Microsoft vendor extensions using * 0xFC1E for VsMsftOpCode. */ index_list[index].msft_opcode = 0xFC1E;