diff mbox series

[net-next,07/10] net: fill in MODULE_DESCRIPTION()s for 6LoWPAN

Message ID 20240108181610.2697017-8-leitao@debian.org (mailing list archive)
State New, archived
Headers show
Series None | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/SubjectPrefix fail "Bluetooth: " prefix is not specified in the subject
tedd_an/BuildKernel success BuildKernel PASS
tedd_an/CheckAllWarning success CheckAllWarning PASS
tedd_an/CheckSparse success CheckSparse PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/BuildKernel32 success BuildKernel32 PASS
tedd_an/TestRunnerSetup success TestRunnerSetup PASS
tedd_an/TestRunner_l2cap-tester success TestRunner PASS
tedd_an/TestRunner_iso-tester success TestRunner PASS
tedd_an/TestRunner_bnep-tester success TestRunner PASS
tedd_an/TestRunner_mgmt-tester success TestRunner PASS
tedd_an/TestRunner_rfcomm-tester success TestRunner PASS
tedd_an/TestRunner_sco-tester success TestRunner PASS
tedd_an/TestRunner_ioctl-tester success TestRunner PASS
tedd_an/TestRunner_mesh-tester success TestRunner PASS
tedd_an/TestRunner_smp-tester success TestRunner PASS
tedd_an/TestRunner_userchan-tester success TestRunner PASS
tedd_an/IncrementalBuild success Incremental Build PASS

Commit Message

Breno Leitao Jan. 8, 2024, 6:16 p.m. UTC 
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to IPv6 over Low power Wireless Personal Area Network.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 net/6lowpan/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Aring Jan. 10, 2024, 1:04 a.m. UTC | #1 
Hi,

On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <leitao@debian.org> wrote:
>
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to IPv6 over Low power Wireless Personal Area Network.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  net/6lowpan/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> index 7b3341cef926..80d83151ef29 100644
> --- a/net/6lowpan/core.c
> +++ b/net/6lowpan/core.c
> @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void)
>
>  module_init(lowpan_module_init);
>  module_exit(lowpan_module_exit);
> -
> +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");

Here is a nitpick as well. The correct acronym [0] is "IPv6 over
Low-Power Wireless Personal Area Network", otherwise it is okay.

Acked-by: Alexander Aring <aahringo@redhat.com>

- Alex
Alexander Aring Jan. 10, 2024, 1:05 a.m. UTC | #2 
Hi,

On Tue, Jan 9, 2024 at 8:04 PM Alexander Aring <aahringo@redhat.com> wrote:
>
> Hi,
>
> On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <leitao@debian.org> wrote:
> >
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to IPv6 over Low power Wireless Personal Area Network.
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> >  net/6lowpan/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> > index 7b3341cef926..80d83151ef29 100644
> > --- a/net/6lowpan/core.c
> > +++ b/net/6lowpan/core.c
> > @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void)
> >
> >  module_init(lowpan_module_init);
> >  module_exit(lowpan_module_exit);
> > -
> > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");
>
> Here is a nitpick as well. The correct acronym [0] is "IPv6 over
> Low-Power Wireless Personal Area Network", otherwise it is okay.
>
> Acked-by: Alexander Aring <aahringo@redhat.com>
>
> - Alex

[0] https://datatracker.ietf.org/wg/6lowpan/about/
Breno Leitao Jan. 10, 2024, 9:19 a.m. UTC | #3 
On Tue, Jan 09, 2024 at 08:04:47PM -0500, Alexander Aring wrote:
> Hi,
> 
> On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <leitao@debian.org> wrote:
> >
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to IPv6 over Low power Wireless Personal Area Network.
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> >  net/6lowpan/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> > index 7b3341cef926..80d83151ef29 100644
> > --- a/net/6lowpan/core.c
> > +++ b/net/6lowpan/core.c
> > @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void)
> >
> >  module_init(lowpan_module_init);
> >  module_exit(lowpan_module_exit);
> > -
> > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");
> 
> Here is a nitpick as well. The correct acronym [0] is "IPv6 over
> Low-Power Wireless Personal Area Network", otherwise it is okay.

Thanks. I will update.
diff mbox series

Patch

diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
index 7b3341cef926..80d83151ef29 100644
--- a/net/6lowpan/core.c
+++ b/net/6lowpan/core.c
@@ -178,5 +178,5 @@  static void __exit lowpan_module_exit(void)
 
 module_init(lowpan_module_init);
 module_exit(lowpan_module_exit);
-
+MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module");
 MODULE_LICENSE("GPL");