[BlueZ,1/3] lib/uuid: Add support to compare 16bit uuids

Commit Message

Ajay KV Feb. 13, 2024, 9:56 p.m. UTC

---
 lib/uuid.c | 9 +++++++++
 lib/uuid.h | 1 +
 2 files changed, 10 insertions(+)

Comments

[e-mail] Feb. 13, 2024, 6:01 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=825717

---Test result---

Test Summary:
CheckPatch                    FAIL      2.27 seconds
GitLint                       FAIL      1.22 seconds
BuildEll                      PASS      24.79 seconds
BluezMake                     PASS      758.67 seconds
MakeCheck                     PASS      12.29 seconds
MakeDistcheck                 PASS      166.57 seconds
CheckValgrind                 PASS      229.92 seconds
CheckSmatch                   PASS      332.05 seconds
bluezmakeextell               PASS      108.19 seconds
IncrementalBuild              PASS      2154.56 seconds
ScanBuild                     WARNING   1005.83 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,1/3] lib/uuid: Add support to compare 16bit uuids
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: lib/uuid.c:126:
+  if (!uuid1 || (uuid1->type != BT_UUID16))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (2, 4)
#89: FILE: lib/uuid.c:126:
+  if (!uuid1 || (uuid1->type != BT_UUID16))
+    return 0;

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#90: FILE: lib/uuid.c:127:
+    return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: lib/uuid.c:129:
+  return (uuid1->value.u16 == uuid2);$

/github/workspace/src/src/13555344.patch total: 0 errors, 4 warnings, 22 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13555344.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


[BlueZ,3/3] shared/ccp: Add initial code for Call Control Profile for Client Role.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#304: FILE: src/shared/ccp.c:202:
+      void *user_data, bt_ccp_destroy_func_t destroy)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#360: FILE: src/shared/ccp.c:258:
+      &uuid, BT_ATT_PERM_READ,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#361: FILE: src/shared/ccp.c:259:
+      BT_GATT_CHRC_PROP_READ | BT_GATT_CHRC_PROP_NOTIFY,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#362: FILE: src/shared/ccp.c:260:
+      ccs_call_state_read, NULL, ccs);$

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#374: FILE: src/shared/ccp.c:272:
+	ccs->bearer_technology = gatt_db_service_add_characteristic(ccs->service,

WARNING:LONG_LINE: line length of 87 exceeds 80 columns
#384: FILE: src/shared/ccp.c:282:
+	ccs->bearer_uri_schemes_list = gatt_db_service_add_characteristic(ccs->service,

WARNING:LONG_LINE: line length of 87 exceeds 80 columns
#401: FILE: src/shared/ccp.c:299:
+	ccs->signal_reporting_intrvl = gatt_db_service_add_characteristic(ccs->service,

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#409: FILE: src/shared/ccp.c:307:
+	ccs->current_call_list = gatt_db_service_add_characteristic(ccs->service,

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#436: FILE: src/shared/ccp.c:334:
+	ccs->target_bearer_uri = gatt_db_service_add_characteristic(ccs->service,

WARNING:LONG_LINE: line length of 84 exceeds 80 columns
#453: FILE: src/shared/ccp.c:351:
+	ccs->call_ctrl_opt_opcode = gatt_db_service_add_characteristic(ccs->service,

WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#455: FILE: src/shared/ccp.c:353:
+			BT_GATT_CHRC_PROP_WRITE | BT_GATT_CHRC_PROP_WRITE_WITHOUT_RESP |

WARNING:LONG_LINE: line length of 84 exceeds 80 columns
#461: FILE: src/shared/ccp.c:359:
+	ccs->call_ctrl_opt_opcode = gatt_db_service_add_characteristic(ccs->service,

WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#468: FILE: src/shared/ccp.c:366:
+	ccs->termination_reason = gatt_db_service_add_characteristic(ccs->service,

WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#595: FILE: src/shared/ccp.c:493:
+static void ccp_cb_status_flag_notify(uint16_t value_handle, const uint8_t *value,

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#600: FILE: src/shared/ccp.c:498:
+  DBG(ccp, "");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#620: FILE: src/shared/ccp.c:518:
+  DBG(ccp, "");$

WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#639: FILE: src/shared/ccp.c:537:
+static void ccp_cb_bearer_name_notify(uint16_t value_handle, const uint8_t *value,

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#686: FILE: src/shared/ccp.c:584:
+static void ccp_cb_call_state_notify(uint16_t value_handle, const uint8_t *value,

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#710: FILE: src/shared/ccp.c:608:
+static void ccp_cb_incom_call_notify(uint16_t value_handle, const uint8_t *value,

WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#730: FILE: src/shared/ccp.c:628:
+	if (!gatt_db_attribute_get_char_data(ccs->incoming_call, NULL, &value_handle,

WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#748: FILE: src/shared/ccp.c:646:
+	if (!gatt_db_attribute_get_char_data(ccs->call_state, NULL, &value_handle,

WARNING:LONG_LINE: line length of 89 exceeds 80 columns
#766: FILE: src/shared/ccp.c:664:
+	if (!gatt_db_attribute_get_char_data(ccs->current_call_list, NULL, &value_handle,

WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#784: FILE: src/shared/ccp.c:682:
+	if (!gatt_db_attribute_get_char_data(ccs->bearer_name, NULL, &value_handle,

WARNING:LONG_LINE: line length of 90 exceeds 80 columns
#802: FILE: src/shared/ccp.c:700:
+	if (!gatt_db_attribute_get_char_data(ccs->termination_reason, NULL, &value_handle,

WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#820: FILE: src/shared/ccp.c:718:
+	if (!gatt_db_attribute_get_char_data(ccs->status_flag, NULL, &value_handle,

WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#838: FILE: src/shared/ccp.c:736:
+	if (!gatt_db_attribute_get_char_data(ccs->bearer_uci, NULL, &value_handle,

WARNING:LONG_LINE: line length of 89 exceeds 80 columns
#856: FILE: src/shared/ccp.c:754:
+	if (!gatt_db_attribute_get_char_data(ccs->bearer_technology, NULL, &value_handle,

WARNING:LONG_LINE: line length of 87 exceeds 80 columns
#873: FILE: src/shared/ccp.c:771:
+	if (!gatt_db_attribute_get_char_data(ccs->signal_strength, NULL, &value_handle,

WARNING:LONG_LINE: line length of 89 exceeds 80 columns
#908: FILE: src/shared/ccp.c:806:
+	if (!gatt_db_attribute_get_char_data(ccs->target_bearer_uri, NULL, &value_handle,

WARNING:LONG_LINE: line length of 87 exceeds 80 columns
#926: FILE: src/shared/ccp.c:824:
+	if (!gatt_db_attribute_get_char_data(ccs->call_ctrl_point, NULL, &value_handle,

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#942: FILE: src/shared/ccp.c:840:
+  DBG(ccp, "");$

WARNING:LONG_LINE: line length of 92 exceeds 80 columns
#944: FILE: src/shared/ccp.c:842:
+	if (!gatt_db_attribute_get_char_data(ccs->call_ctrl_opt_opcode, NULL, &value_handle,

WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#950: FILE: src/shared/ccp.c:848:
+	ccp->call_control_opt_opcode_id = bt_gatt_client_register_notify(ccp->client,

WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#962: FILE: src/shared/ccp.c:860:
+	if (!gatt_db_attribute_get_char_data(ccs->friendly_name, NULL, &value_handle,

WARNING:LONG_LINE: line length of 95 exceeds 80 columns
#980: FILE: src/shared/ccp.c:878:
+	if (!gatt_db_attribute_get_char_data(ccs->signal_reporting_intrvl, NULL, &value_handle,

WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#986: FILE: src/shared/ccp.c:884:
+	ccp->signal_reporting_intrvl_id = bt_gatt_client_register_notify(ccp->client,

WARNING:LONG_LINE: line length of 95 exceeds 80 columns
#998: FILE: src/shared/ccp.c:896:
+	if (!gatt_db_attribute_get_char_data(ccs->bearer_uri_schemes_list, NULL, &value_handle,

WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#1004: FILE: src/shared/ccp.c:902:
+	ccp->bearer_uri_schemes_list_id = bt_gatt_client_register_notify(ccp->client,

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#1039: FILE: src/shared/ccp.c:937:
+		DBG(ccp, "Found Bearer Technology, handle 0x%04x", value_handle);

WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#1109: FILE: src/shared/ccp.c:1007:
+		DBG(ccp, "Found Termination Reason, handle 0x%04x", value_handle);

WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#1269: FILE: src/shared/ccp.h:14:
+#define __packed __attribute__((packed))

/github/workspace/src/src/13555346.patch total: 0 errors, 41 warnings, 1199 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13555346.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,2/3] lib/uuid: Add GTBS UUIDS for Call Control Profile.

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T3 Title has trailing punctuation (.): "[BlueZ,2/3] lib/uuid: Add GTBS UUIDS for Call Control Profile."
[BlueZ,3/3] shared/ccp: Add initial code for Call Control Profile for Client Role.

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (82>80): "[BlueZ,3/3] shared/ccp: Add initial code for Call Control Profile for Client Role."
1: T3 Title has trailing punctuation (.): "[BlueZ,3/3] shared/ccp: Add initial code for Call Control Profile for Client Role."
##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
Makefile:13696: warning: overriding recipe for target 'install-data-hook'
Makefile:13691: warning: ignoring old recipe for target 'install-data-hook'
Makefile:13696: warning: overriding recipe for target 'install-data-hook'
Makefile:13691: warning: ignoring old recipe for target 'install-data-hook'
src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
        gatt_db_unregister(op->client->db, op->db_id);
                           ^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
        discovery_op_complete(op, false, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:993:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1099:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1291:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1356:2: warning: Use of memory after it is freed
        discovery_op_complete(op, success, att_ecode);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1631:6: warning: Use of memory after it is freed
        if (read_db_hash(op)) {
            ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1636:2: warning: Use of memory after it is freed
        discover_all(op);
        ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2140:6: warning: Use of memory after it is freed
        if (read_db_hash(op)) {
            ^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2148:8: warning: Use of memory after it is freed
                                                        discovery_op_ref(op),
                                                        ^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3237:2: warning: Use of memory after it is freed
        complete_write_long_op(req, success, 0, false);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3259:2: warning: Use of memory after it is freed
        request_unref(req);
        ^~~~~~~~~~~~~~~~~~
12 warnings generated.



---
Regards,
Linux Bluetooth

[e-mail] Feb. 13, 2024, 8:50 p.m. UTC | #2

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Tue, 13 Feb 2024 23:56:58 +0200 you wrote:
> ---
>  lib/uuid.c | 9 +++++++++
>  lib/uuid.h | 1 +
>  2 files changed, 10 insertions(+)

Here is the summary with links:
  - [BlueZ,1/3] lib/uuid: Add support to compare 16bit uuids
    (no matching commit)
  - [BlueZ,2/3] lib/uuid: Add GTBS UUIDS for Call Control Profile.
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=24d97e35fcde
  - [BlueZ,3/3] shared/ccp: Add initial code for Call Control Profile for Client Role.
    (no matching commit)

You are awesome, thank you!

Patch

diff --git a/lib/uuid.c b/lib/uuid.c
index 1d2e1f7328b8..3ef45db5408c 100644
--- a/lib/uuid.c
+++ b/lib/uuid.c
@@ -120,6 +120,15 @@  int bt_uuid_cmp(const bt_uuid_t *uuid1, const bt_uuid_t *uuid2)
 	return bt_uuid128_cmp(&u1, &u2);
 }
 
+int bt_uuid16_cmp(const bt_uuid_t *uuid1, uint16_t uuid2)
+{
+
+  if (!uuid1 || (uuid1->type != BT_UUID16))
+    return 0;
+
+  return (uuid1->value.u16 == uuid2);
+}
+
 /*
  * convert the UUID to string, copying a maximum of n characters.
  */
diff --git a/lib/uuid.h b/lib/uuid.h
index 8839dea08140..124e74985a80 100644
--- a/lib/uuid.h
+++ b/lib/uuid.h
@@ -242,6 +242,7 @@  int bt_uuid32_create(bt_uuid_t *btuuid, uint32_t value);
 int bt_uuid128_create(bt_uuid_t *btuuid, uint128_t value);
 
 int bt_uuid_cmp(const bt_uuid_t *uuid1, const bt_uuid_t *uuid2);
+int bt_uuid16_cmp(const bt_uuid_t *uuid1, uint16_t uuid2);
 void bt_uuid_to_uuid128(const bt_uuid_t *src, bt_uuid_t *dst);
 
 #define MAX_LEN_UUID_STR 37