diff mbox series

[BlueZ] Don't install conf and state dir on systemd

Message ID 20240304142200.69968-1-mg@max.gautier.name (mailing list archive)
State Accepted
Commit 7665fb5d943c3910465123fc7b08922e44adb7a2
Headers show
Series [BlueZ] Don't install conf and state dir on systemd | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Max Gautier March 4, 2024, 2:21 p.m. UTC 
The bluetooth.service file already specify the State and Configuration
directories with the correct modes, which guarantee they will be
available (with proper permissions) when bluetoohd starts.

Not installing those helps implementing the "Hermetic /usr" pattern
(TL;DR: '/usr' contains everything necessary to boostrap a working
system)

Handling this in upstream bluez (rather than in distribution packaging
scripts) avoid duplication of efforts between distros.

Links: https://0pointer.net/blog/fitting-everything-together.html
---
 Makefile.am | 5 +++++
 1 file changed, 5 insertions(+)

Comments

bluez.test.bot@gmail.com March 4, 2024, 3:32 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=832119

---Test result---

Test Summary:
CheckPatch                    PASS      0.41 seconds
GitLint                       PASS      0.31 seconds
BuildEll                      PASS      25.01 seconds
BluezMake                     PASS      725.21 seconds
MakeCheck                     PASS      11.83 seconds
MakeDistcheck                 PASS      166.95 seconds
CheckValgrind                 PASS      229.44 seconds
CheckSmatch                   PASS      340.07 seconds
bluezmakeextell               PASS      109.26 seconds
IncrementalBuild              PASS      670.91 seconds
ScanBuild                     PASS      965.73 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org March 4, 2024, 9 p.m. UTC | #2 
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon,  4 Mar 2024 15:21:57 +0100 you wrote:
> The bluetooth.service file already specify the State and Configuration
> directories with the correct modes, which guarantee they will be
> available (with proper permissions) when bluetoohd starts.
> 
> Not installing those helps implementing the "Hermetic /usr" pattern
> (TL;DR: '/usr' contains everything necessary to boostrap a working
> system)
> 
> [...]

Here is the summary with links:
  - [BlueZ] Don't install conf and state dir on systemd
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7665fb5d943c

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Makefile.am b/Makefile.am
index d94839856..ed4f9dc51 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -422,7 +422,12 @@  include Makefile.obexd
 include android/Makefile.am
 include Makefile.mesh
 
+if SYSTEMD
+install-data-hook: obexd-add-service-symlink
+else
 install-data-hook: bluetoothd-fix-permissions obexd-add-service-symlink
+endif
+
 uninstall-hook: obexd-remove-service-symlink
 
 if HID2HCI