[v2] Bluetooth: btnxpuart: Enable Power Save feature on startup

Commit Message

Neeraj Sanjay Kale March 4, 2024, 5:07 p.m. UTC

This sets the default power save mode setting to enabled.

The power save feature is now stable and stress test issues, such as the
TX timeout error, have been resolved.
commit c7ee0bc8db32 ("Bluetooth: btnxpuart: Resolve TX timeout error in
power save stress test")

With this setting, the driver will send the vendor command to FW at
startup, to enable power save feature.

User can disable this feature using the following vendor command:
hcitool cmd 3f 23 03 00 00 (HCI_NXP_AUTO_SLEEP_MODE)

Signed-off-by: Neeraj Sanjay Kale <[e-mail]>
Reviewed-by: Paul Menzel <[e-mail]>
---
v2: Corrected subject line. Added commit reference. (Paul Menzel)
 drivers/bluetooth/btnxpuart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

[e-mail] March 4, 2024, 5:56 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=832171

---Test result---

Test Summary:
CheckPatch                    PASS      0.62 seconds
GitLint                       PASS      0.29 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      28.12 seconds
CheckAllWarning               PASS      31.50 seconds
CheckSparse                   PASS      36.84 seconds
CheckSmatch                   PASS      101.40 seconds
BuildKernel32                 PASS      27.66 seconds
TestRunnerSetup               PASS      508.70 seconds
TestRunner_l2cap-tester       PASS      20.25 seconds
TestRunner_iso-tester         PASS      32.80 seconds
TestRunner_bnep-tester        PASS      4.75 seconds
TestRunner_mgmt-tester        PASS      113.13 seconds
TestRunner_rfcomm-tester      PASS      7.40 seconds
TestRunner_sco-tester         PASS      14.92 seconds
TestRunner_ioctl-tester       PASS      7.85 seconds
TestRunner_mesh-tester        FAIL      6.11 seconds
TestRunner_smp-tester         PASS      6.91 seconds
TestRunner_userchan-tester    PASS      5.01 seconds
IncrementalBuild              PASS      26.54 seconds

Details
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 9 (90.0%), Failed: 1, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Failed       0.104 seconds


---
Regards,
Linux Bluetooth

Francesco Dolcini March 4, 2024, 7:29 p.m. UTC | #2

On Mon, Mar 04, 2024 at 10:37:53PM +0530, Neeraj Sanjay Kale wrote:
> This sets the default power save mode setting to enabled.
> 
> The power save feature is now stable and stress test issues, such as the
> TX timeout error, have been resolved.

I assume that the stability issue has been fixed in firmware, correct?
What's going to happen if running the updated driver with old firmware?
What about combo Wi-Fi/BT firmware files, were those updated? I'm
currently using this driver with this firmware [1]

[1] https://github.com/nxp-imx/imx-firmware/blob/lf-5.15.52_2.1.0/nxp/FwImage_IW416_SD/sdiouartiw416_combo_v0.bin

Francesco

Neeraj Sanjay Kale March 15, 2024, 1:13 p.m. UTC | #3

Hi Francesco,

> 
> On Mon, Mar 04, 2024 at 10:37:53PM +0530, Neeraj Sanjay Kale wrote:
> > This sets the default power save mode setting to enabled.
> >
> > The power save feature is now stable and stress test issues, such as
> > the TX timeout error, have been resolved.
> 
> I assume that the stability issue has been fixed in firmware, correct?
> What's going to happen if running the updated driver with old firmware?
> What about combo Wi-Fi/BT firmware files, were those updated? I'm
> currently using this driver with this firmware [1]

There were some stability issues in the driver, that are fixed in previous patches.

As for FW, I have checked internally and there were no power save related issues reported for any combo FWs.

I had requested our QA team to perform basic sanity tests for WLAN and BT using the exact FW version you are using, and there were no power save issues reported.

Thanks,
Neeraj

Francesco Dolcini March 15, 2024, 3:42 p.m. UTC | #4

Hello,

On Fri, Mar 15, 2024 at 01:13:36PM +0000, Neeraj Sanjay Kale wrote:
> > On Mon, Mar 04, 2024 at 10:37:53PM +0530, Neeraj Sanjay Kale wrote:
> > > This sets the default power save mode setting to enabled.
> > >
> > > The power save feature is now stable and stress test issues, such as
> > > the TX timeout error, have been resolved.
> > 
> > I assume that the stability issue has been fixed in firmware, correct?
> > What's going to happen if running the updated driver with old firmware?
> > What about combo Wi-Fi/BT firmware files, were those updated? I'm
> > currently using this driver with this firmware [1]
> 
> There were some stability issues in the driver, that are fixed in previous patches.
> 
> As for FW, I have checked internally and there were no power save related
> issues reported for any combo FWs.

Thanks for the information,

Francesco

Patch

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 7f88b6f52f26..42e929f0d141 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -281,7 +281,7 @@  static u8 crc8_table[CRC8_TABLE_SIZE];
 
 /* Default configurations */
 #define DEFAULT_H2C_WAKEUP_MODE	WAKEUP_METHOD_BREAK
-#define DEFAULT_PS_MODE		PS_MODE_DISABLE
+#define DEFAULT_PS_MODE		PS_MODE_ENABLE
 #define FW_INIT_BAUDRATE	HCI_NXP_PRI_BAUDRATE
 
 static struct sk_buff *nxp_drv_send_cmd(struct hci_dev *hdev, u16 opcode,