[1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

Commit Message

Marek Vasut March 9, 2024, 3:15 a.m. UTC

CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
This chip is present e.g. on muRata 1YN module. Extend the
binding with its DT compatible.

Signed-off-by: Marek Vasut <[e-mail]>
---
Cc: "David S. Miller" <[e-mail]>
Cc: Conor Dooley <[e-mail]>
Cc: Eric Dumazet <[e-mail]>
Cc: Jakub Kicinski <[e-mail]>
Cc: Krzysztof Kozlowski <[e-mail]>
Cc: Linus Walleij <[e-mail]>
Cc: Luiz Augusto von Dentz <[e-mail]>
Cc: Marcel Holtmann <[e-mail]>
Cc: Paolo Abeni <[e-mail]>
Cc: Rob Herring <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
---
 Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

[e-mail] March 9, 2024, 3:56 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=833965

---Test result---

Test Summary:
CheckPatch                    PASS      1.03 seconds
GitLint                       PASS      0.50 seconds
SubjectPrefix                 FAIL      0.37 seconds
BuildKernel                   PASS      27.67 seconds
CheckAllWarning               PASS      30.60 seconds
CheckSparse                   PASS      35.91 seconds
CheckSmatch                   PASS      98.04 seconds
BuildKernel32                 PASS      26.54 seconds
TestRunnerSetup               PASS      502.39 seconds
TestRunner_l2cap-tester       PASS      17.73 seconds
TestRunner_iso-tester         PASS      28.22 seconds
TestRunner_bnep-tester        PASS      4.67 seconds
TestRunner_mgmt-tester        PASS      112.79 seconds
TestRunner_rfcomm-tester      PASS      7.24 seconds
TestRunner_sco-tester         PASS      14.84 seconds
TestRunner_ioctl-tester       PASS      7.67 seconds
TestRunner_mesh-tester        PASS      5.73 seconds
TestRunner_smp-tester         PASS      6.77 seconds
TestRunner_userchan-tester    PASS      4.91 seconds
IncrementalBuild              PASS      30.09 seconds

Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject


---
Regards,
Linux Bluetooth

Krzysztof Kozlowski March 9, 2024, 11:39 a.m. UTC | #2

On 09/03/2024 04:15, Marek Vasut wrote:
> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
> This chip is present e.g. on muRata 1YN module. Extend the
> binding with its DT compatible.
> 
> Signed-off-by: Marek Vasut <[e-mail]>
> ---
> Cc: "David S. Miller" <[e-mail]>

Acked-by: Krzysztof Kozlowski <[e-mail]>

Best regards,
Krzysztof

Conor Dooley March 17, 2024, 3:03 p.m. UTC | #3

On Sat, Mar 09, 2024 at 04:15:12AM +0100, Marek Vasut wrote:
> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
> This chip is present e.g. on muRata 1YN module. Extend the
> binding with its DT compatible.

How come there's no fallback here? Looking at the binding patch there's
no device-specific handling done, what's incompatibly different between
this device and some of the other ones supported by the hci_bcm driver?

> 
> Signed-off-by: Marek Vasut <[e-mail]>
> ---
> Cc: "David S. Miller" <[e-mail]>
> Cc: Conor Dooley <[e-mail]>
> Cc: Eric Dumazet <[e-mail]>
> Cc: Jakub Kicinski <[e-mail]>
> Cc: Krzysztof Kozlowski <[e-mail]>
> Cc: Linus Walleij <[e-mail]>
> Cc: Luiz Augusto von Dentz <[e-mail]>
> Cc: Marcel Holtmann <[e-mail]>
> Cc: Paolo Abeni <[e-mail]>
> Cc: Rob Herring <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> ---
>  Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> index cc70b00c6ce57..670bff0078ed7 100644
> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> @@ -27,6 +27,7 @@ properties:
>        - brcm,bcm4335a0
>        - brcm,bcm4349-bt
>        - cypress,cyw4373a0-bt
> +      - infineon,cyw43439-bt
>        - infineon,cyw55572-bt
>  
>    shutdown-gpios:
> -- 
> 2.43.0
>

Marek Vasut March 19, 2024, 6:07 p.m. UTC | #4

On 3/17/24 4:03 PM, Conor Dooley wrote:
> On Sat, Mar 09, 2024 at 04:15:12AM +0100, Marek Vasut wrote:
>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>> This chip is present e.g. on muRata 1YN module. Extend the
>> binding with its DT compatible.
> 
> How come there's no fallback here? Looking at the binding patch there's
> no device-specific handling done, what's incompatibly different between
> this device and some of the other ones supported by the hci_bcm driver?

For posterity, should be addressed in V2.

Patch

diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
index cc70b00c6ce57..670bff0078ed7 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
@@ -27,6 +27,7 @@  properties:
       - brcm,bcm4335a0
       - brcm,bcm4349-bt
       - cypress,cyw4373a0-bt
+      - infineon,cyw43439-bt
       - infineon,cyw55572-bt
 
   shutdown-gpios: