| Message ID | 20240510121355.3241456-14-hadess@hadess.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6f041df23ecf263ad80e1f3f952cbd67183ec3e6 |
| Headers | show |
| Series | Fix a number of static analysis issues | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 4: B1 Line exceeds max length (95>80): "bluez-5.75/client/player.c:1846:6: original: "qos->sync_cte_type" looks like the original copy." 5: B1 Line exceeds max length (123>80): "bluez-5.75/client/player.c:1852:6: copy_paste_error: "sync_cte_type" in "qos->sync_cte_type" looks like a copy-paste error." 7: B3 Line contains hard tab characters (\t): "1850| }" 9: B3 Line contains hard tab characters (\t): "1852|-> if (qos->sync_cte_type) {" 10: B3 Line contains hard tab characters (\t): "1853| bt_shell_printf("MSE %u\n", qos->mse);" 11: B3 Line contains hard tab characters (\t): "1854| g_dbus_dict_append_entry(iter, "MSE", DBUS_TYPE_BYTE," |
diff --git a/client/player.c b/client/player.c index 6b70e9ed3f9d..7f67425aaf8f 100644 --- a/client/player.c +++ b/client/player.c @@ -1849,7 +1849,7 @@ static void append_bcast_qos(DBusMessageIter *iter, struct endpoint_config *cfg) &qos->sync_cte_type); } - if (qos->sync_cte_type) { + if (qos->mse) { bt_shell_printf("MSE %u\n", qos->mse); g_dbus_dict_append_entry(iter, "MSE", DBUS_TYPE_BYTE, &qos->mse);
Error: COPY_PASTE_ERROR (CWE-398): [#def95] [important] bluez-5.75/client/player.c:1846:6: original: "qos->sync_cte_type" looks like the original copy. bluez-5.75/client/player.c:1852:6: copy_paste_error: "sync_cte_type" in "qos->sync_cte_type" looks like a copy-paste error. bluez-5.75/client/player.c:1852:6: remediation: Should it say "mse" instead? 1850| } 1851| 1852|-> if (qos->sync_cte_type) { 1853| bt_shell_printf("MSE %u\n", qos->mse); 1854| g_dbus_dict_append_entry(iter, "MSE", DBUS_TYPE_BYTE, --- client/player.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)