| Context |
Check |
Description |
| tedd_an/pre-ci_am |
success
|
Success
|
| tedd_an/CheckPatch |
warning
|
WARNING:LINE_SPACING: Missing a blank line after declarations
#75: FILE: tools/isotest.c:1462:
+ char *tmp = filename;
+ filename = strdup(strchr(filename, ',') + 1);
/github/workspace/src/src/13665901.patch total: 0 errors, 1 warnings, 13 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13665901.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
|
| tedd_an/GitLint |
fail
|
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
4: B1 Line exceeds max length (86>80): "bluez-5.75/tools/isotest.c:1461:5: address: Taking offset from "strchr(filename, 44)"."
5: B1 Line exceeds max length (94>80): "bluez-5.75/tools/isotest.c:1461:5: assign: Assigning: "filename" = "strchr(filename, 44) + 1"."
6: B1 Line exceeds max length (93>80): "bluez-5.75/tools/isotest.c:1536:2: incorrect_free: "free" frees incorrect pointer "filename"."
9: B3 Line contains hard tab characters (\t): "1536|-> free(filename);"
11: B3 Line contains hard tab characters (\t): "1538| syslog(LOG_INFO, "Exit");"
|
| tedd_an/IncrementalBuild |
success
|
Incremental Build PASS
|
@@ -1457,8 +1457,11 @@ int main(int argc, char *argv[])
switch (mode) {
case SEND:
send_mode(filename, argv[optind + i], i, repeat);
- if (filename && strchr(filename, ','))
- filename = strchr(filename, ',') + 1;
+ if (filename && strchr(filename, ',')) {
+ char *tmp = filename;
+ filename = strdup(strchr(filename, ',') + 1);
+ free(tmp);
+ }
break;
case RECONNECT: