| Message ID | 20240516090340.61417-11-hadess@hadess.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 566af9c2f5efaa33ebb093efb3a03f83876943ba |
| Headers | show |
| Series | Fix a number of static analysis issues #2 | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 4: B1 Line exceeds max length (89>80): "bluez-5.75/tools/test-runner.c:877:3: open_fn: Returning handle opened by "attach_proto"." 5: B1 Line exceeds max length (147>80): "bluez-5.75/tools/test-runner.c:877:3: var_assign: Assigning: "serial_fd" = handle returned from "attach_proto(node, 0U, basic_flags, extra_flags)"." 6: B1 Line exceeds max length (117>80): "bluez-5.75/tools/test-runner.c:955:3: leaked_handle: Handle variable "serial_fd" going out of scope leaks the handle." 7: B3 Line contains hard tab characters (\t): "953| if (pid < 0) {" 8: B3 Line contains hard tab characters (\t): "954| perror("Failed to fork new process");" 9: B3 Line contains hard tab characters (\t): "955|-> return;" 10: B3 Line contains hard tab characters (\t): "956| }" |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
diff --git a/tools/test-runner.c b/tools/test-runner.c index 908327255ad7..de0f2260480c 100644 --- a/tools/test-runner.c +++ b/tools/test-runner.c @@ -952,6 +952,8 @@ start_next: pid = fork(); if (pid < 0) { perror("Failed to fork new process"); + if (serial_fd >= 0) + close(serial_fd); return; }
Error: RESOURCE_LEAK (CWE-772): [#def65] [important] bluez-5.75/tools/test-runner.c:877:3: open_fn: Returning handle opened by "attach_proto". bluez-5.75/tools/test-runner.c:877:3: var_assign: Assigning: "serial_fd" = handle returned from "attach_proto(node, 0U, basic_flags, extra_flags)". bluez-5.75/tools/test-runner.c:955:3: leaked_handle: Handle variable "serial_fd" going out of scope leaks the handle. 953| if (pid < 0) { 954| perror("Failed to fork new process"); 955|-> return; 956| } 957| --- tools/test-runner.c | 2 ++ 1 file changed, 2 insertions(+)