| Message ID | 20240618195914.2470373-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0dc5bb2ed6798c25a451516f95c747a60014978b |
| Headers | show |
| Series | [BlueZ,v1] gas: Fix reading attributes on every connection | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=863185 ---Test result--- Test Summary: CheckPatch PASS 0.42 seconds GitLint PASS 0.30 seconds BuildEll PASS 25.24 seconds BluezMake PASS 1704.22 seconds MakeCheck PASS 13.18 seconds MakeDistcheck PASS 177.53 seconds CheckValgrind PASS 251.05 seconds CheckSmatch PASS 354.30 seconds bluezmakeextell PASS 120.32 seconds IncrementalBuild PASS 1491.98 seconds ScanBuild PASS 1009.63 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 18 Jun 2024 15:59:14 -0400 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > Attributes only need to be read once after that they will be persisted > by the core so there is no need to keep reading them on every > reconnection. > --- > profiles/gap/gas.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Here is the summary with links: - [BlueZ,v1] gas: Fix reading attributes on every connection https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0dc5bb2ed679 You are awesome, thank you!
diff --git a/profiles/gap/gas.c b/profiles/gap/gas.c index dbe5f003bfba..08aaf19cb332 100644 --- a/profiles/gap/gas.c +++ b/profiles/gap/gas.c @@ -342,6 +342,10 @@ static int gap_accept(struct btd_service *service) goto _finish; } + /* Check if attribute already has been discovered */ + if (gas->attr) + goto _finish; + gas->db = gatt_db_ref(db); gas->client = bt_gatt_client_clone(client); @@ -364,10 +368,6 @@ _finish: static int gap_disconnect(struct btd_service *service) { - struct gas *gas = btd_service_get_user_data(service); - - gas_reset(gas); - btd_service_disconnecting_complete(service, 0); return 0;
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Attributes only need to be read once after that they will be persisted by the core so there is no need to keep reading them on every reconnection. --- profiles/gap/gas.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)