[v1] Bluetooth : Update the mas session structure

Commit Message

Amisha Jain June 24, 2024, 6:36 a.m. UTC

Update the 'mas_session' structure such that manager_emit_transfer_property(os->service_data, "Size")
will get the proper structure in arguments as expected like structure 'obex_transfer' and transfer->path
won't be populated with inappropriate value.

As there is no new tranfer registered during mas connect, hence setting the path to NULL
to avoid invoking the g_dbus_emit_property_changed() property.

Signed-off-by: Amisha Jain <[e-mail]>
---
 obexd/plugins/mas.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

[e-mail] June 24, 2024, 8:44 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=864750

---Test result---

Test Summary:
CheckPatch                    FAIL      0.64 seconds
GitLint                       FAIL      0.46 seconds
BuildEll                      PASS      25.47 seconds
BluezMake                     PASS      1668.39 seconds
MakeCheck                     PASS      13.04 seconds
MakeDistcheck                 PASS      184.98 seconds
CheckValgrind                 PASS      260.17 seconds
CheckSmatch                   PASS      369.87 seconds
bluezmakeextell               PASS      125.46 seconds
IncrementalBuild              PASS      1529.93 seconds
ScanBuild                     PASS      1098.93 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[v1] Bluetooth : Update the mas session structure
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#94: 
Update the 'mas_session' structure such that manager_emit_transfer_property(os->service_data, "Size")

WARNING:TYPO_SPELLING: 'tranfer' may be misspelled - perhaps 'transfer'?
#98: 
As there is no new tranfer registered during mas connect, hence setting the path to NULL
                   ^^^^^^^

/github/workspace/src/src/13709034.patch total: 0 errors, 2 warnings, 22 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13709034.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[v1] Bluetooth : Update the mas session structure

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
3: B1 Line exceeds max length (101>80): "Update the 'mas_session' structure such that manager_emit_transfer_property(os->service_data, "Size")"
4: B1 Line exceeds max length (104>80): "will get the proper structure in arguments as expected like structure 'obex_transfer' and transfer->path"
7: B1 Line exceeds max length (88>80): "As there is no new tranfer registered during mas connect, hence setting the path to NULL"


---
Regards,
Linux Bluetooth

Patch

diff --git a/obexd/plugins/mas.c b/obexd/plugins/mas.c
index 10b972d65..71bf12ad3 100644
--- a/obexd/plugins/mas.c
+++ b/obexd/plugins/mas.c
@@ -51,6 +51,8 @@ 
 #define ML_BODY_END "</MAP-msg-listing>"
 
 struct mas_session {
+	uint8_t notification_status;
+	char *path;
 	struct mas_request *request;
 	void *backend_data;
 	gboolean finished;
@@ -59,7 +61,6 @@  struct mas_session {
 	GObexApparam *inparams;
 	GObexApparam *outparams;
 	gboolean ap_sent;
-	uint8_t notification_status;
 };
 
 static const uint8_t MAS_TARGET[TARGET_SIZE] = {
@@ -125,6 +126,7 @@  static void *mas_connect(struct obex_session *os, int *err)
 		goto failed;
 
 	manager_register_session(os);
+	mas->path = NULL;
 
 	return mas;