| Message ID | 20240628075719.42796-1-r.smirnov@omp.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0ddcfaeafad6ae71b3495bdfb174773aceb3e996 |
| Headers | show |
| Series | [BlueZ,v2] gatt-server: fix memory leak in bt_gatt_server_send_notification() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING src/shared/gatt-server.c:278:25: warning: Variable length array is used.src/shared/gatt-server.c:621:25: warning: Variable length array is used.src/shared/gatt-server.c:720:25: warning: Variable length array is used.src/shared/gatt-server.c:278:25: warning: Variable length array is used.src/shared/gatt-server.c:621:25: warning: Variable length array is used.src/shared/gatt-server.c:720:25: warning: Variable length array is used.src/shared/gatt-server.c:278:25: warning: Variable length array is used.src/shared/gatt-server.c:621:25: warning: Variable length array is used.src/shared/gatt-server.c:720:25: warning: Variable length array is used. |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=866451 ---Test result--- Test Summary: CheckPatch PASS 0.26 seconds GitLint PASS 0.20 seconds BuildEll PASS 25.21 seconds BluezMake PASS 1761.46 seconds MakeCheck PASS 13.72 seconds MakeDistcheck PASS 191.98 seconds CheckValgrind PASS 263.42 seconds CheckSmatch WARNING 365.33 seconds bluezmakeextell PASS 125.57 seconds IncrementalBuild PASS 1546.59 seconds ScanBuild PASS 1033.94 seconds Details ############################## Test: CheckSmatch - WARNING Desc: Run smatch tool with source Output: src/shared/gatt-server.c:278:25: warning: Variable length array is used.src/shared/gatt-server.c:621:25: warning: Variable length array is used.src/shared/gatt-server.c:720:25: warning: Variable length array is used.src/shared/gatt-server.c:278:25: warning: Variable length array is used.src/shared/gatt-server.c:621:25: warning: Variable length array is used.src/shared/gatt-server.c:720:25: warning: Variable length array is used.src/shared/gatt-server.c:278:25: warning: Variable length array is used.src/shared/gatt-server.c:621:25: warning: Variable length array is used.src/shared/gatt-server.c:720:25: warning: Variable length array is used. --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Fri, 28 Jun 2024 10:57:18 +0300 you wrote: > data-pdu is allocated but not released when an error occurs. > > Add data-pdu release before exiting the function in case of an error. > > Found by Linux Verification Center (linuxtesting.org) with the SVACE > static analysis tool. > > [...] Here is the summary with links: - [BlueZ,v2] gatt-server: fix memory leak in bt_gatt_server_send_notification() https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0ddcfaeafad6 You are awesome, thank you!
diff --git a/src/shared/gatt-server.c b/src/shared/gatt-server.c index 0e399ceb1..3a53d5dfd 100644 --- a/src/shared/gatt-server.c +++ b/src/shared/gatt-server.c @@ -1822,8 +1822,10 @@ bool bt_gatt_server_send_notification(struct bt_gatt_server *server, return result; error: - if (data) + if (data) { + free(data->pdu); free(data); + } return false; }