[BlueZ,v1] shared/vcp: add NULL checks to foreach_aics_service()

Commit Message

Roman Smirnov July 2, 2024, 8:55 a.m. UTC

Make foreach_aics_service() safe for passing NULL pointers.

Found with the SVACE static analysis tool.
---
 src/shared/vcp.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

[e-mail] July 2, 2024, 10:41 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=867451

---Test result---

Test Summary:
CheckPatch                    PASS      0.44 seconds
GitLint                       PASS      0.31 seconds
BuildEll                      PASS      25.07 seconds
BluezMake                     PASS      1697.26 seconds
MakeCheck                     PASS      13.52 seconds
MakeDistcheck                 PASS      176.92 seconds
CheckValgrind                 PASS      253.95 seconds
CheckSmatch                   PASS      354.89 seconds
bluezmakeextell               PASS      120.31 seconds
IncrementalBuild              PASS      1450.21 seconds
ScanBuild                     PASS      1008.57 seconds



---
Regards,
Linux Bluetooth

Patch

diff --git a/src/shared/vcp.c b/src/shared/vcp.c
index b7e17e448..1f84da4a0 100644
--- a/src/shared/vcp.c
+++ b/src/shared/vcp.c
@@ -2714,6 +2714,9 @@  static void foreach_aics_service(struct gatt_db_attribute *attr,
 	struct bt_vcp *vcp = user_data;
 	struct bt_aics *aics = vcp_get_aics(vcp);
 
+	if (!aics || !attr)
+		return;
+
 	aics->service = attr;
 
 	gatt_db_service_set_claimed(attr, true);