| Message ID | 20240702115138.70500-1-r.smirnov@omp.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 12525371ef082483d524447310da7d0f5866bf91 |
| Headers | show |
| Series | [BlueZ,v1] client/player: add return value check of io_get_fd() to transport_recv() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (83>80): "[BlueZ,v1] client/player: add return value check of io_get_fd() to transport_recv()" |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=867513 ---Test result--- Test Summary: CheckPatch PASS 10.17 seconds GitLint FAIL 2.19 seconds BuildEll PASS 24.83 seconds BluezMake PASS 1732.88 seconds MakeCheck PASS 13.23 seconds MakeDistcheck PASS 178.96 seconds CheckValgrind PASS 254.56 seconds CheckSmatch PASS 361.49 seconds bluezmakeextell PASS 121.59 seconds IncrementalBuild PASS 1498.74 seconds ScanBuild PASS 1034.92 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [BlueZ,v1] client/player: add return value check of io_get_fd() to transport_recv() WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (83>80): "[BlueZ,v1] client/player: add return value check of io_get_fd() to transport_recv()" --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 2 Jul 2024 14:51:38 +0300 you wrote: > It is necessary to add return value check as in sock_send(). > > Found with the SVACE static analysis tool. > --- > client/player.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Here is the summary with links: - [BlueZ,v1] client/player: add return value check of io_get_fd() to transport_recv() https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=12525371ef08 You are awesome, thank you!
diff --git a/client/player.c b/client/player.c index 7a7598c39..b1ebcaa37 100644 --- a/client/player.c +++ b/client/player.c @@ -4514,7 +4514,13 @@ static bool transport_recv(struct io *io, void *user_data) uint8_t buf[1024]; int ret, len; - ret = read(io_get_fd(io), buf, sizeof(buf)); + ret = io_get_fd(io); + if (ret < 0) { + bt_shell_printf("io_get_fd() returned %d\n", ret); + return true; + } + + ret = read(ret, buf, sizeof(buf)); if (ret < 0) { bt_shell_printf("Failed to read: %s (%d)\n", strerror(errno), -errno);