[BlueZ,v1] shared/shell: add return value check of io_get_fd() to input_read()

Commit Message

Roman Smirnov July 2, 2024, 2:03 p.m. UTC

It is necessary to add a return value check.

Found with the SVACE static analysis tool.
---
 src/shared/shell.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

[e-mail] July 2, 2024, 3:40 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=867571

---Test result---

Test Summary:
CheckPatch                    PASS      0.26 seconds
GitLint                       PASS      0.19 seconds
BuildEll                      PASS      24.82 seconds
BluezMake                     PASS      1728.14 seconds
MakeCheck                     PASS      13.76 seconds
MakeDistcheck                 PASS      177.84 seconds
CheckValgrind                 PASS      252.10 seconds
CheckSmatch                   WARNING   358.33 seconds
bluezmakeextell               PASS      119.41 seconds
IncrementalBuild              PASS      1461.06 seconds
ScanBuild                     PASS      1001.32 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):


---
Regards,
Linux Bluetooth

[e-mail] July 3, 2024, 3:10 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Tue, 2 Jul 2024 17:03:13 +0300 you wrote:
> It is necessary to add a return value check.
> 
> Found with the SVACE static analysis tool.
> ---
>  src/shared/shell.c | 5 +++++
>  1 file changed, 5 insertions(+)

Here is the summary with links:
  - [BlueZ,v1] shared/shell: add return value check of io_get_fd() to input_read()
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ee46e92bdef4

You are awesome, thank you!

Patch

diff --git a/src/shared/shell.c b/src/shared/shell.c
index 2ecc41bf3..add4fa131 100644
--- a/src/shared/shell.c
+++ b/src/shared/shell.c
@@ -289,6 +289,11 @@  static bool input_read(struct io *io, void *user_data)
 
 	fd = io_get_fd(io);
 
+	if (fd < 0) {
+		printf("io_get_fd() returned %d\n", fd);
+		return false;
+	}
+
 	if (fd == STDIN_FILENO) {
 		rl_callback_read_char();
 		return true;