[v7,1/8] Bluetooth: btusb: mediatek: remove the unnecessary goto tag

Commit Message

Chris Lu July 4, 2024, 6:01 a.m. UTC

Remove the unnecessary goto tag whether there is an error or not, we have
to free the buffer at the end of the function.

Signed-off-by: Sean Wang <[e-mail]>
Signed-off-by: Chris Lu <[e-mail]>
---
 drivers/bluetooth/btusb.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

[e-mail] July 4, 2024, 6:39 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=868302

---Test result---

Test Summary:
CheckPatch                    PASS      8.26 seconds
GitLint                       PASS      2.58 seconds
SubjectPrefix                 PASS      0.99 seconds
BuildKernel                   PASS      30.28 seconds
CheckAllWarning               PASS      32.33 seconds
CheckSparse                   PASS      39.03 seconds
CheckSmatch                   PASS      104.20 seconds
BuildKernel32                 PASS      28.58 seconds
TestRunnerSetup               PASS      522.48 seconds
TestRunner_l2cap-tester       PASS      20.23 seconds
TestRunner_iso-tester         PASS      32.98 seconds
TestRunner_bnep-tester        PASS      4.86 seconds
TestRunner_mgmt-tester        PASS      114.02 seconds
TestRunner_rfcomm-tester      PASS      7.47 seconds
TestRunner_sco-tester         PASS      15.07 seconds
TestRunner_ioctl-tester       PASS      7.91 seconds
TestRunner_mesh-tester        PASS      7.91 seconds
TestRunner_smp-tester         PASS      6.92 seconds
TestRunner_userchan-tester    PASS      5.03 seconds
IncrementalBuild              PASS      67.83 seconds



---
Regards,
Linux Bluetooth

Patch

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 79aefdb3324d..fcdd660add19 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2953,12 +2953,9 @@  static int btusb_mtk_uhw_reg_write(struct btusb_data *data, u32 reg, u32 val)
 			      0x5E,
 			      reg >> 16, reg & 0xffff,
 			      buf, 4, USB_CTRL_SET_TIMEOUT);
-	if (err < 0) {
+	if (err < 0)
 		bt_dev_err(hdev, "Failed to write uhw reg(%d)", err);
-		goto err_free_buf;
-	}
 
-err_free_buf:
 	kfree(buf);
 
 	return err;