diff mbox series

[BlueZ,v2,2/3] client/player: fix the order of args in cmd_register_endpoint()

Message ID 20240704090756.31351-3-r.smirnov@omp.ru (mailing list archive)
State New
Headers show
Series fix errors found by SVACE static analyzer | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/IncrementalBuild success Incremental Build PASS

Commit Message

Roman Smirnov July 4, 2024, 9:07 a.m. UTC 
Based on the function prototype, ep->cid and ep->vid should be swapped.

Found with the SVACE static analysis tool.
---
 V1 -> V2: the patch header is now shorter
 client/player.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/client/player.c b/client/player.c
index 0d031e4b0..2569b38e9 100644
--- a/client/player.c
+++ b/client/player.c
@@ -3388,7 +3388,7 @@  static void cmd_register_endpoint(int argc, char *argv[])
 
 	if (strrchr(argv[2], ':')) {
 		ep->codec = 0xff;
-		parse_vendor_codec(argv[2], &ep->cid, &ep->vid);
+		parse_vendor_codec(argv[2], &ep->vid, &ep->cid);
 		ep->preset = new0(struct preset, 1);
 		ep->preset->custom.name = strdup("custom");
 		ep->preset->default_preset = &ep->preset->custom;