| tedd_an/GitLint |
fail
|
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
4: B1 Line exceeds max length (146>80): "bluez-5.76/tools/btsnoop.c:438:2: tainted_data_return: Called function "read(fd, buf, toread)", and a possible return value may be less than zero."
5: B1 Line exceeds max length (85>80): "bluez-5.76/tools/btsnoop.c:438:2: assign: Assigning: "len" = "read(fd, buf, toread)"."
6: B1 Line exceeds max length (147>80): "bluez-5.76/tools/btsnoop.c:473:4: overflow: The cast of "len - 9L", which is potentially negative, to an unsigned type could result in an overflow."
7: B3 Line contains hard tab characters (\t): "471| /* next 4 bytes are data len and cid */"
8: B3 Line contains hard tab characters (\t): "472| current_cid = buf[8] << 8 | buf[7];"
9: B3 Line contains hard tab characters (\t): "473|-> memcpy(pdu_buf, buf + 9, len - 9);"
10: B3 Line contains hard tab characters (\t): "474| pdu_len = len - 9;"
11: B3 Line contains hard tab characters (\t): "475| } else if (acl_flags & 0x01) {"
14: B1 Line exceeds max length (146>80): "bluez-5.76/tools/btsnoop.c:438:2: tainted_data_return: Called function "read(fd, buf, toread)", and a possible return value may be less than zero."
15: B1 Line exceeds max length (85>80): "bluez-5.76/tools/btsnoop.c:438:2: assign: Assigning: "len" = "read(fd, buf, toread)"."
16: B1 Line exceeds max length (147>80): "bluez-5.76/tools/btsnoop.c:476:4: overflow: The cast of "len - 5L", which is potentially negative, to an unsigned type could result in an overflow."
17: B3 Line contains hard tab characters (\t): "474| pdu_len = len - 9;"
18: B3 Line contains hard tab characters (\t): "475| } else if (acl_flags & 0x01) {"
19: B3 Line contains hard tab characters (\t): "476|-> memcpy(pdu_buf + pdu_len, buf + 5, len - 5);"
20: B3 Line contains hard tab characters (\t): "477| pdu_len += len - 5;"
21: B3 Line contains hard tab characters (\t): "478| }"
|
Error: INTEGER_OVERFLOW (CWE-190): [#def41] [important] bluez-5.76/tools/btsnoop.c:438:2: tainted_data_return: Called function "read(fd, buf, toread)", and a possible return value may be less than zero. bluez-5.76/tools/btsnoop.c:438:2: assign: Assigning: "len" = "read(fd, buf, toread)". bluez-5.76/tools/btsnoop.c:473:4: overflow: The cast of "len - 9L", which is potentially negative, to an unsigned type could result in an overflow. 471| /* next 4 bytes are data len and cid */ 472| current_cid = buf[8] << 8 | buf[7]; 473|-> memcpy(pdu_buf, buf + 9, len - 9); 474| pdu_len = len - 9; 475| } else if (acl_flags & 0x01) { Error: INTEGER_OVERFLOW (CWE-190): [#def42] [important] bluez-5.76/tools/btsnoop.c:438:2: tainted_data_return: Called function "read(fd, buf, toread)", and a possible return value may be less than zero. bluez-5.76/tools/btsnoop.c:438:2: assign: Assigning: "len" = "read(fd, buf, toread)". bluez-5.76/tools/btsnoop.c:476:4: overflow: The cast of "len - 5L", which is potentially negative, to an unsigned type could result in an overflow. 474| pdu_len = len - 9; 475| } else if (acl_flags & 0x01) { 476|-> memcpy(pdu_buf + pdu_len, buf + 5, len - 5); 477| pdu_len += len - 5; 478| } --- tools/btsnoop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)