| Message ID | 20240708074454.5891-1-quic_prathm@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 42d43b28428f93f36febdb4969c0a8526281d9ab |
| Headers | show |
| Series | [BlueZ] Set BREDR not supported bit in AD Flag when discoverable is off | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=869180 ---Test result--- Test Summary: CheckPatch PASS 0.29 seconds GitLint PASS 0.23 seconds BuildEll PASS 24.63 seconds BluezMake PASS 1623.95 seconds MakeCheck PASS 13.69 seconds MakeDistcheck PASS 179.01 seconds CheckValgrind PASS 256.87 seconds CheckSmatch PASS 355.04 seconds bluezmakeextell PASS 118.64 seconds IncrementalBuild PASS 1489.47 seconds ScanBuild PASS 1004.70 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 8 Jul 2024 13:14:54 +0530 you wrote: > From: Prathibha Madugonde <quic_prathm@quicinc.com> > > Fix for GAP/DISC/NONM/BV-02-C > As per GAP.TS.p44 test spec > IUT does not contain General Discoverable mode and Limited Discoverable > mode in the AD Type Flag. IUT shall send AD Type Flag to PASS the test > case, thus set BR/EDR not supported bit in the AD Type Flag when > discoverable is off. > > [...] Here is the summary with links: - [BlueZ] Set BREDR not supported bit in AD Flag when discoverable is off https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=42d43b28428f You are awesome, thank you!
diff --git a/src/advertising.c b/src/advertising.c index 5d373e088..af3ed2b93 100644 --- a/src/advertising.c +++ b/src/advertising.c @@ -734,8 +734,7 @@ static bool set_flags(struct btd_adv_client *client, uint8_t flags) /* Set BR/EDR Not Supported if adapter is not discoverable but the * instance is. */ - if ((flags & (BT_AD_FLAG_GENERAL | BT_AD_FLAG_LIMITED)) && - !btd_adapter_get_discoverable(client->manager->adapter)) + if (!btd_adapter_get_discoverable(client->manager->adapter)) flags |= BT_AD_FLAG_NO_BREDR; if (!bt_ad_add_flags(client->data, &flags, 1))
From: Prathibha Madugonde <quic_prathm@quicinc.com> Fix for GAP/DISC/NONM/BV-02-C As per GAP.TS.p44 test spec IUT does not contain General Discoverable mode and Limited Discoverable mode in the AD Type Flag. IUT shall send AD Type Flag to PASS the test case, thus set BR/EDR not supported bit in the AD Type Flag when discoverable is off. Test steps: From DUT, bluetoothctl go to menu advertise set discoverable to off and then advertise on. In AD Flags BR/EDR not supported BIT shall be set. --- src/advertising.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)