diff mbox series

[BlueZ] tools/btmgmt: Fix --index option for non-interactive mode

Message ID 20240709115541.66118-1-arjan@opmeer.net (mailing list archive)
State Accepted
Commit f00d5546c9e989dd68ce0de0190cd0e043b0f1f5
Headers show
Series [BlueZ] tools/btmgmt: Fix --index option for non-interactive mode | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Arjan Opmeer July 9, 2024, 11:55 a.m. UTC
In non-interactive mode the --index option does not work because the
call to mgmt_set_index() is made after bt_shell_attach().
See also https://github.com/bluez/bluez/issues/893

---
 tools/btmgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com July 9, 2024, 1:53 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=869637

---Test result---

Test Summary:
CheckPatch                    PASS      0.38 seconds
GitLint                       PASS      0.27 seconds
BuildEll                      PASS      24.65 seconds
BluezMake                     PASS      1645.25 seconds
MakeCheck                     PASS      13.60 seconds
MakeDistcheck                 PASS      178.83 seconds
CheckValgrind                 PASS      253.40 seconds
CheckSmatch                   PASS      356.17 seconds
bluezmakeextell               PASS      120.42 seconds
IncrementalBuild              PASS      1467.28 seconds
ScanBuild                     PASS      1001.55 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org July 9, 2024, 2:50 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  9 Jul 2024 13:55:41 +0200 you wrote:
> In non-interactive mode the --index option does not work because the
> call to mgmt_set_index() is made after bt_shell_attach().
> See also https://github.com/bluez/bluez/issues/893
> 
> ---
>  tools/btmgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] tools/btmgmt: Fix --index option for non-interactive mode
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f00d5546c9e9

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/btmgmt.c b/tools/btmgmt.c
index 9b7f851bd..436c2bb21 100644
--- a/tools/btmgmt.c
+++ b/tools/btmgmt.c
@@ -51,8 +51,8 @@  int main(int argc, char *argv[])
 		return EXIT_FAILURE;
 	}
 
-	bt_shell_attach(fileno(stdin));
 	mgmt_set_index(index_option);
+	bt_shell_attach(fileno(stdin));
 	status = bt_shell_run();
 
 	mgmt_remove_submenu();