diff mbox series

[v1] Bluetooth: hci_qca: Fix build error

Message ID 20240711023256.3546349-1-luiz.dentz@gmail.com (mailing list archive)
State Superseded
Headers show
Series [v1] Bluetooth: hci_qca: Fix build error | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/SubjectPrefix success Gitlint PASS
tedd_an/BuildKernel success BuildKernel PASS
tedd_an/CheckAllWarning warning CheckSparse WARNING drivers/bluetooth/hci_qca.c: In function ‘qca_serdev_remove’:drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_INVALID’ not handled in switch [-Wswitch] 2490 | switch (qcadev->btsoc_type) { | ^~~~~~drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_AR3002’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_ROME’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA2066’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA6390’ not handled in switch [-Wswitch]
tedd_an/CheckSparse warning CheckSparse WARNING drivers/bluetooth/hci_qca.c: In function ‘qca_serdev_remove’:drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_INVALID’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_AR3002’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_ROME’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA2066’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA6390’ not handled in switch [-Wswitch]
tedd_an/CheckSmatch warning CheckSparse WARNING drivers/bluetooth/hci_qca.c: In function ‘qca_serdev_remove’:drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_INVALID’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_AR3002’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_ROME’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA2066’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA6390’ not handled in switch [-Wswitch]
tedd_an/BuildKernel32 success BuildKernel32 PASS
tedd_an/TestRunnerSetup success TestRunnerSetup PASS
tedd_an/TestRunner_l2cap-tester success TestRunner PASS
tedd_an/TestRunner_iso-tester success TestRunner PASS
tedd_an/TestRunner_bnep-tester success TestRunner PASS
tedd_an/TestRunner_mgmt-tester success TestRunner PASS
tedd_an/TestRunner_rfcomm-tester success TestRunner PASS
tedd_an/TestRunner_sco-tester success TestRunner PASS
tedd_an/TestRunner_ioctl-tester success TestRunner PASS
tedd_an/TestRunner_mesh-tester success TestRunner PASS
tedd_an/TestRunner_smp-tester success TestRunner PASS
tedd_an/TestRunner_userchan-tester success TestRunner PASS
tedd_an/IncrementalBuild success Incremental Build PASS

Commit Message

Luiz Augusto von Dentz July 11, 2024, 2:32 a.m. UTC 
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes the following build error introduced by a887c8dede8e
("Bluetooth: hci_qca: schedule a devm action for disabling the clock"):

drivers/bluetooth/hci_qca.c: In function ‘qca_serdev_remove’:
drivers/bluetooth/hci_qca.c:2501:2: error: label at end of compound statement
 2501 |  default:
      |  ^~~~~~~

Fixes: a887c8dede8e ("Bluetooth: hci_qca: schedule a devm action for disabling the clock")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 drivers/bluetooth/hci_qca.c | 1 -
 1 file changed, 1 deletion(-)

Comments

bluez.test.bot@gmail.com July 11, 2024, 3 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=870300

---Test result---

Test Summary:
CheckPatch                    PASS      0.67 seconds
GitLint                       PASS      0.34 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      36.71 seconds
CheckAllWarning               WARNING   32.19 seconds
CheckSparse                   WARNING   37.65 seconds
CheckSmatch                   WARNING   101.79 seconds
BuildKernel32                 PASS      28.62 seconds
TestRunnerSetup               PASS      526.18 seconds
TestRunner_l2cap-tester       PASS      21.98 seconds
TestRunner_iso-tester         PASS      36.66 seconds
TestRunner_bnep-tester        PASS      4.79 seconds
TestRunner_mgmt-tester        PASS      112.12 seconds
TestRunner_rfcomm-tester      PASS      7.43 seconds
TestRunner_sco-tester         PASS      14.95 seconds
TestRunner_ioctl-tester       PASS      7.85 seconds
TestRunner_mesh-tester        PASS      5.92 seconds
TestRunner_smp-tester         PASS      6.87 seconds
TestRunner_userchan-tester    PASS      5.02 seconds
IncrementalBuild              PASS      27.85 seconds

Details
##############################
Test: CheckAllWarning - WARNING
Desc: Run linux kernel with all warning enabled
Output:
drivers/bluetooth/hci_qca.c: In function ‘qca_serdev_remove’:drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_INVALID’ not handled in switch [-Wswitch] 2490 |  switch (qcadev->btsoc_type) {      |  ^~~~~~drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_AR3002’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_ROME’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA2066’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA6390’ not handled in switch [-Wswitch]
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
drivers/bluetooth/hci_qca.c: In function ‘qca_serdev_remove’:drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_INVALID’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_AR3002’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_ROME’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA2066’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA6390’ not handled in switch [-Wswitch]
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
drivers/bluetooth/hci_qca.c: In function ‘qca_serdev_remove’:drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_INVALID’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_AR3002’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_ROME’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA2066’ not handled in switch [-Wswitch]drivers/bluetooth/hci_qca.c:2490:2: warning: enumeration value ‘QCA_QCA6390’ not handled in switch [-Wswitch]


---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 030153d468bf..2664c994734a 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -2498,7 +2498,6 @@  static void qca_serdev_remove(struct serdev_device *serdev)
 		if (power->vregs_on)
 			qca_power_shutdown(&qcadev->serdev_hu);
 		break;
-	default:
 	}
 
 	hci_uart_unregister_device(&qcadev->serdev_hu);