[v2] Bluetooth: hci_qca: Fix build error

Commit Message

Luiz Augusto von Dentz July 11, 2024, 3:22 a.m. UTC

From: Luiz Augusto von Dentz <[e-mail]>

This fixes the following build error introduced by a887c8dede8e
("Bluetooth: hci_qca: schedule a devm action for disabling the clock"):

drivers/bluetooth/hci_qca.c: In function ‘qca_serdev_remove’:
drivers/bluetooth/hci_qca.c:2501:2: error: label at end of compound statement
 2501 |  default:
      |  ^~~~~~~

Fixes: a887c8dede8e ("Bluetooth: hci_qca: schedule a devm action for disabling the clock")
Signed-off-by: Luiz Augusto von Dentz <[e-mail]>
---
 drivers/bluetooth/hci_qca.c | 1 +
 1 file changed, 1 insertion(+)

Comments

[e-mail] July 11, 2024, 3:59 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=870309

---Test result---

Test Summary:
CheckPatch                    PASS      0.67 seconds
GitLint                       PASS      0.30 seconds
SubjectPrefix                 PASS      0.11 seconds
BuildKernel                   PASS      29.69 seconds
CheckAllWarning               PASS      32.18 seconds
CheckSparse                   PASS      37.86 seconds
CheckSmatch                   PASS      103.90 seconds
BuildKernel32                 PASS      28.80 seconds
TestRunnerSetup               PASS      527.58 seconds
TestRunner_l2cap-tester       PASS      21.94 seconds
TestRunner_iso-tester         FAIL      34.60 seconds
TestRunner_bnep-tester        PASS      4.79 seconds
TestRunner_mgmt-tester        FAIL      112.95 seconds
TestRunner_rfcomm-tester      PASS      7.40 seconds
TestRunner_sco-tester         PASS      16.98 seconds
TestRunner_ioctl-tester       PASS      8.42 seconds
TestRunner_mesh-tester        PASS      6.08 seconds
TestRunner_smp-tester         PASS      6.87 seconds
TestRunner_userchan-tester    PASS      4.97 seconds
IncrementalBuild              PASS      27.54 seconds

Details
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 117 (95.9%), Failed: 1, Not Run: 4

Failed Test Cases
ISO Connect2 Suspend - Success                       Failed       4.235 seconds
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2

Failed Test Cases
LL Privacy - Start Discovery 2 (Disable RL)          Failed       0.190 seconds


---
Regards,
Linux Bluetooth

[e-mail] July 11, 2024, 8:44 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Wed, 10 Jul 2024 23:22:52 -0400 you wrote:
> From: Luiz Augusto von Dentz <[e-mail]>
> 
> This fixes the following build error introduced by a887c8dede8e
> ("Bluetooth: hci_qca: schedule a devm action for disabling the clock"):
> 
> drivers/bluetooth/hci_qca.c: In function ‘qca_serdev_remove’:
> drivers/bluetooth/hci_qca.c:2501:2: error: label at end of compound statement
>  2501 |  default:
>       |  ^~~~~~~
> 
> [...]

Here is the summary with links:
  - [v2] Bluetooth: hci_qca: Fix build error
    https://git.kernel.org/bluetooth/bluetooth-next/c/f14c0bb78769

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 030153d468bf..ca6466676902 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -2499,6 +2499,7 @@  static void qca_serdev_remove(struct serdev_device *serdev)
 			qca_power_shutdown(&qcadev->serdev_hu);
 		break;
 	default:
+		break;
 	}
 
 	hci_uart_unregister_device(&qcadev->serdev_hu);