| Message ID | 20240718180059.1159551-2-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 957c956112cc2bba528fe8df4a0a21d221a617ca |
| Headers | show |
| Series | [BlueZ,v1] client/player: Fix printing errors when transport->filename is not set | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (81>80): "[BlueZ,v1] client/player: Fix printing errors when transport->filename is not set" |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 18 Jul 2024 14:00:59 -0400 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > If transport->filename is not set don't attempt to write to the > transport->fd. > --- > client/player.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [BlueZ,v1] client/player: Fix printing errors when transport->filename is not set https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=957c956112cc You are awesome, thank you!
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=872320 ---Test result--- Test Summary: CheckPatch PASS 0.28 seconds GitLint FAIL 0.45 seconds BuildEll PASS 24.53 seconds BluezMake PASS 1714.39 seconds MakeCheck PASS 13.34 seconds MakeDistcheck PASS 177.16 seconds CheckValgrind PASS 251.47 seconds CheckSmatch PASS 352.97 seconds bluezmakeextell PASS 119.81 seconds IncrementalBuild PASS 1489.81 seconds ScanBuild PASS 999.96 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [BlueZ,v1] client/player: Fix printing errors when transport->filename is not set WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (81>80): "[BlueZ,v1] client/player: Fix printing errors when transport->filename is not set" --- Regards, Linux Bluetooth
diff --git a/client/player.c b/client/player.c index a368c9c710ca..fdb62bac5f4c 100644 --- a/client/player.c +++ b/client/player.c @@ -4892,10 +4892,10 @@ static bool transport_recv(struct io *io, void *user_data) transport->seq++; - if (transport->fd >= 0) { + if (transport->filename) { len = write(transport->fd, buf, ret); if (len < 0) - bt_shell_printf("Unable to write: %s (%d)", + bt_shell_printf("Unable to write: %s (%d)\n", strerror(errno), -errno); }
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> If transport->filename is not set don't attempt to write to the transport->fd. --- client/player.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)