diff mbox series

[BlueZ,1/1] bap: Update default sync_factor

Message ID 20240726101015.263668-2-vlad.pruteanu@nxp.com (mailing list archive)
State New, archived
Headers show
Series bap: Update default sync_factor | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Vlad Pruteanu July 26, 2024, 10:10 a.m. UTC 
Formula for extended advertising interval set by kernel for Bcast:

interval = (qos->bcast.out.interval / 1250) * qos->bcast.sync_factor;
sync_interval = interval * 4;

According to CORE SPECIFICATION Version 5.4 | Vol 4, Part E page 2451,
the extended advertising interval should be at least 0x20 (32). Thus,
interval should be at least 8. If qos->bcast.out.interval = 7500,
it follows that the sync_factor should be at least 2.
---
 profiles/audio/bap.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com July 26, 2024, 11:41 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=874045

---Test result---

Test Summary:
CheckPatch                    PASS      0.37 seconds
GitLint                       PASS      0.45 seconds
BuildEll                      PASS      24.64 seconds
BluezMake                     PASS      1684.44 seconds
MakeCheck                     PASS      13.09 seconds
MakeDistcheck                 PASS      179.75 seconds
CheckValgrind                 PASS      253.39 seconds
CheckSmatch                   PASS      356.90 seconds
bluezmakeextell               PASS      120.30 seconds
IncrementalBuild              PASS      1451.44 seconds
ScanBuild                     PASS      1014.48 seconds



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 53f430d66..ad722ebb0 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -871,7 +871,10 @@  static struct bap_setup *setup_new(struct bap_ep *ep)
 		/* Mark BIG and BIS to be auto assigned */
 		setup->qos.bcast.big = BT_ISO_QOS_BIG_UNSET;
 		setup->qos.bcast.bis = BT_ISO_QOS_BIS_UNSET;
-		setup->qos.bcast.sync_factor = 0x01;
+		/* sync_factor should be >=2 to avoid invalid extended
+		 * advertising interval value
+		 */
+		setup->qos.bcast.sync_factor = 0x02;
 		setup->qos.bcast.sync_timeout = BT_ISO_SYNC_TIMEOUT;
 		setup->qos.bcast.timeout = BT_ISO_SYNC_TIMEOUT;
 		setup->qos_parser = setup_parse_bcast_qos;